Issue 10915163: Fix 5024 - diagnostic on unresolved catch types, added test case

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10915163: Fix 5024 - diagnostic on unresolved catch types, added test case (Closed)

Created:
8 years, 3 months ago by aam-me

Modified:
8 years, 3 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix 5024 - diagnostic on unresolved catch types, added test case BUG=5024 TEST= Committed: https://code.google.com/p/dart/source/detail?r=12095

Patch Set 2 : Fixed test. #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	lib/compiler/implementation/resolver.dart	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	tests/language/try_catch_on_syntax_test.dart	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM if you fix the test. https://chromiumcodereview.appspot.com/10915163/diff/1/tests/language/try_catch_on_syntax_test.dart File tests/language/try_catch_on_syntax_test.dart (right): https://chromiumcodereview.appspot.com/10915163/diff/1/tests/language/try_catch_on_syntax_test.dart#newcode31 tests/language/try_catch_on_syntax_test.dart:31: catch(e) {} This ...

8 years, 3 months ago (2012-09-09 15:48:44 UTC) #1

aam-me

Okay, done! https://chromiumcodereview.appspot.com/10915163/diff/1/tests/language/try_catch_on_syntax_test.dart File tests/language/try_catch_on_syntax_test.dart (right): https://chromiumcodereview.appspot.com/10915163/diff/1/tests/language/try_catch_on_syntax_test.dart#newcode31 tests/language/try_catch_on_syntax_test.dart:31: catch(e) {} On 2012/09/09 15:48:44, ahe wrote: ...

8 years, 3 months ago (2012-09-09 16:03:09 UTC) #2

Still LGTM!

Expand Messages | Collapse Messages

Issue 10915163: Fix 5024 - diagnostic on unresolved catch types, added test case (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fixed test. #

Messages