Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 10915104: Move namer into javascript backend. (Closed)

Created:
8 years, 3 months ago by floitsch
Modified:
8 years, 3 months ago
Reviewers:
ngeoffray, kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Move namer into javascript backend. Committed: https://code.google.com/p/dart/source/detail?r=11937

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -413 lines) Patch
M lib/compiler/implementation/closure.dart View 1 chunk +34 lines, -3 lines 1 comment Download
M lib/compiler/implementation/compiler.dart View 3 chunks +4 lines, -2 lines 1 comment Download
M lib/compiler/implementation/js_backend/backend.dart View 2 chunks +5 lines, -2 lines 0 comments Download
M lib/compiler/implementation/js_backend/emitter.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M lib/compiler/implementation/js_backend/js_backend.dart View 1 chunk +1 line, -0 lines 0 comments Download
A + lib/compiler/implementation/js_backend/namer.dart View 1 chunk +0 lines, -32 lines 0 comments Download
M lib/compiler/implementation/js_backend/native_emitter.dart View 7 chunks +12 lines, -11 lines 0 comments Download
M lib/compiler/implementation/leg.dart View 1 chunk +0 lines, -1 line 0 comments Download
D lib/compiler/implementation/namer.dart View 1 chunk +0 lines, -313 lines 0 comments Download
M lib/compiler/implementation/native_handler.dart View 1 chunk +2 lines, -1 line 0 comments Download
M lib/compiler/implementation/ssa/builder.dart View 6 chunks +6 lines, -4 lines 0 comments Download
M lib/compiler/implementation/ssa/codegen.dart View 26 chunks +36 lines, -36 lines 0 comments Download
M lib/compiler/implementation/universe.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
floitsch
https://chromiumcodereview.appspot.com/10915104/diff/1/lib/compiler/implementation/closure.dart File lib/compiler/implementation/closure.dart (right): https://chromiumcodereview.appspot.com/10915104/diff/1/lib/compiler/implementation/closure.dart#newcode448 lib/compiler/implementation/closure.dart:448: String closureName(Element element) { code directly copied from the ...
8 years, 3 months ago (2012-09-05 21:27:46 UTC) #1
kasperl
LGTM. https://chromiumcodereview.appspot.com/10915104/diff/1/lib/compiler/implementation/compiler.dart File lib/compiler/implementation/compiler.dart (right): https://chromiumcodereview.appspot.com/10915104/diff/1/lib/compiler/implementation/compiler.dart#newcode215 lib/compiler/implementation/compiler.dart:215: js_backend.Namer get namer => (backend as js_backend.JavaScriptBackend).namer; This ...
8 years, 3 months ago (2012-09-06 07:47:53 UTC) #2
ngeoffray
8 years, 3 months ago (2012-09-06 07:56:51 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698