Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10915031: Issue 4796. Support for renaming named parameters in invocations (Closed)

Created:
8 years, 3 months ago by scheglov
Modified:
8 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+337 lines, -133 lines) Patch
M compiler/java/com/google/dart/compiler/ast/DartNamedExpression.java View 1 chunk +1 line, -1 line 0 comments Download
M compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java View 10 chunks +44 lines, -13 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java View 4 chunks +20 lines, -20 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/index/contributor/IndexContributor.java View 2 chunks +21 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/index/util/ElementFactory.java View 1 chunk +7 lines, -0 lines 2 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/search/SearchEngineImpl.java View 4 chunks +42 lines, -25 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/search/MatchKind.java View 1 chunk +5 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/ast/DartAstUtilities.java View 3 chunks +12 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/search/SearchEngineTest.java View 6 chunks +106 lines, -60 lines 2 comments Download
M editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/utilities/ast/DartElementLocatorTest.java View 1 chunk +18 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/codemanipulation/StubUtility.java View 2 chunks +3 lines, -11 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/rename/RenameLocalVariableProcessor.java View 3 chunks +18 lines, -3 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/refactoring/RenameLocalVariableProcessorTest.java View 1 chunk +40 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
8 years, 3 months ago (2012-08-31 14:42:14 UTC) #1
Brian Wilkerson
LGTM https://chromiumcodereview.appspot.com/10915031/diff/1/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/index/util/ElementFactory.java File editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/index/util/ElementFactory.java (right): https://chromiumcodereview.appspot.com/10915031/diff/1/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/index/util/ElementFactory.java#newcode195 editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/index/util/ElementFactory.java:195: // XXX nit: Remove the useless comment. https://chromiumcodereview.appspot.com/10915031/diff/1/editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/search/SearchEngineTest.java ...
8 years, 3 months ago (2012-08-31 15:05:36 UTC) #2
scheglov
8 years, 3 months ago (2012-08-31 15:12:52 UTC) #3 
https://chromiumcodereview.appspot.com/10915031/diff/1/editor/tools/plugins/c...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/index/util/ElementFactory.java
(right):

https://chromiumcodereview.appspot.com/10915031/diff/1/editor/tools/plugins/c...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/index/util/ElementFactory.java:195:
// XXX
On 2012/08/31 15:05:36, Brian Wilkerson wrote:
> nit: Remove the useless comment.

Done.

https://chromiumcodereview.appspot.com/10915031/diff/1/editor/tools/plugins/c...
File
editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/search/SearchEngineTest.java
(right):

https://chromiumcodereview.appspot.com/10915031/diff/1/editor/tools/plugins/c...
editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/search/SearchEngineTest.java:143:
//      DartProject moneyProject = getMoneyProject();
On 2012/08/31 15:05:36, Brian Wilkerson wrote:
> nit: Unless there's value that I'm not seeing for keeping the commented out
> lines, please delete them.

Done.

Powered by Google App Engine
This is Rietveld 408576698