Issue 10915026: We can throw an exception but we cannot deoptimize at a runtime call.

Issue 10915026: We can throw an exception but we cannot deoptimize at a runtime call. (Closed)

Created:
8 years, 3 months ago by srdjan

Modified:
8 years, 3 months ago

Reviewers:
regis

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

We can throw an exception but we cannot deoptimize at a runtime call. Remove deopt ids at runtime calls. Mark several computations/instructions that they cannot deoptimize. Committed: https://code.google.com/p/dart/source/detail?r=11693

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 4

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -99 lines)			Patch
M	runtime/vm/flow_graph_compiler_ia32.h	View	1 2 3 4	2 chunks	+3 lines, -6 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View	1 2 3 4	7 chunks	+8 lines, -13 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.h	View	1 2 3 4	2 chunks	+3 lines, -6 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1 2 3 4	7 chunks	+8 lines, -14 lines	0 comments	Download
M	runtime/vm/il_printer.cc	View	1 2 3 4	2 chunks	+4 lines, -4 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1 2 3 4 5	12 chunks	+10 lines, -18 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1 2 3 4	3 chunks	+3 lines, -6 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1 2 3 4	8 chunks	+8 lines, -16 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 2 3 4	8 chunks	+8 lines, -16 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://chromiumcodereview.appspot.com/10915026/diff/9002/runtime/vm/intermediate_language.h File runtime/vm/intermediate_language.h (right): https://chromiumcodereview.appspot.com/10915026/diff/9002/runtime/vm/intermediate_language.h#newcode3068 runtime/vm/intermediate_language.h:3068: : token_pos_(token_pos) { } one line? https://chromiumcodereview.appspot.com/10915026/diff/9002/runtime/vm/intermediate_language.h#newcode3092 runtime/vm/intermediate_language.h:3092: ...

8 years, 3 months ago (2012-08-31 01:20:41 UTC) #2

srdjan

8 years, 3 months ago (2012-08-31 15:24:01 UTC) #3

https://chromiumcodereview.appspot.com/10915026/diff/9002/runtime/vm/intermed...
File runtime/vm/intermediate_language.h (right):

https://chromiumcodereview.appspot.com/10915026/diff/9002/runtime/vm/intermed...
runtime/vm/intermediate_language.h:3068: : token_pos_(token_pos) { }
On 2012/08/31 01:20:41, regis wrote:
> one line?

Done.

https://chromiumcodereview.appspot.com/10915026/diff/9002/runtime/vm/intermed...
runtime/vm/intermediate_language.h:3092: : token_pos_(token_pos) { }
On 2012/08/31 01:20:41, regis wrote:
> one line?

Done.

Expand Messages | Collapse Messages