Issue 10915015: Make fewer assumptions about the layout of api handles.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10915015: Make fewer assumptions about the layout of api handles. (Closed)

Created:
8 years, 3 months ago by turnidge

Modified:
8 years, 3 months ago

Reviewers:
cshapiro

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Make fewer assumptions about the layout of api handles. Found these problems by changing the layout and seeing what broke. Committed: https://code.google.com/p/dart/source/detail?r=11647

Patch Set 2 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -4 lines)			Patch
M	runtime/vm/dart_api_impl.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/dart_api_state.h	View	1	3 chunks	+4 lines, -2 lines	0 comments	Download
M	runtime/vm/scavenger.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

cshapiro

lgtm https://chromiumcodereview.appspot.com/10915015/diff/1/runtime/vm/dart_api_impl.h File runtime/vm/dart_api_impl.h (right): https://chromiumcodereview.appspot.com/10915015/diff/1/runtime/vm/dart_api_impl.h#newcode116 runtime/vm/dart_api_impl.h:116: // TODO(turnidge): Assumes RawObject* is at offset zero. ...

8 years, 3 months ago (2012-08-30 18:18:55 UTC) #2

turnidge

8 years, 3 months ago (2012-08-30 18:24:30 UTC) #3

https://chromiumcodereview.appspot.com/10915015/diff/1/runtime/vm/dart_api_im...
File runtime/vm/dart_api_impl.h (right):

https://chromiumcodereview.appspot.com/10915015/diff/1/runtime/vm/dart_api_im...
runtime/vm/dart_api_impl.h:116: // TODO(turnidge): Assumes RawObject* is at
offset zero.  Fix.
On 2012/08/30 18:18:55, cshapiro wrote:
> Is there a straight forward fix?  Since the handle type is ambiguous, this
would
> require reorganizing handles so they have a similar layout.

I see us always forcing LocalHandle, PersistentHandle, and FPHandle to have a
similar layout prefix.  My only problem here is that LocalHandle hasn't been
defined yet.  To fix this, I would refactor dart_api_state.h and dart_api_impl.h
to make the handle types available at this point.  It's worth hacking up
dart_api_state.h in some way eventually I think.

Expand Messages | Collapse Messages

Issue 10915015: Make fewer assumptions about the layout of api handles. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages