Issue 5049. Consistently resolve instance/static/top-level property access

Issue 5049. Consistently resolve instance/static/top-level property access

print(x) = getter
x += 1   = getter
x++      = getter
++x      = getter
x = 1    = setter


R=brianwilkerson@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=12231

[Brian Wilkerson, 2012-09-11 22:22:43]

LGTM as far as resolving the original issue, but I have a higher level concern.
I'm not sure we can do this in dartc, but I'm concerned about the following
cases:

x += 1
x++
++x

They all reference both the getter and the setter, but by arbitrarily choosing
only one we're loosing information that needs to go into the index. If the
getter (or setter) were renamed independently of the other (not sure whether we
even support that) we could miss references that need to be changed. We also
loose references when searching for references/callers.

[scheglov, 2012-09-11 22:33:02]

Agree, it was not easy to choose one or other.
We could attempt to don't resolve to MethodElement at all, and use FieldElement.
Now, when I thought about this second time, it looks for me that original reason
for resolving to MethodElement was to be able to find references. But it looks
for me that there was much easier way to solve this problem. It was just not
know/convenient for me at that time. But now... I'm pretty comfortable in
IndexContributor.

So, may be NOT commit this?
Instead, I could rewrite to keep FieldElement and search return references for
both getter and setter.
One trick is that we need to check to don't rename references two times - for
getter and setter.

Other related problem: a[0]++
Here are also have call of two operators: [] and []=.
Should we create something like ArrayElement with references to [] and []=?

[Brian Wilkerson, 2012-09-11 23:23:52]

> So, may be NOT commit this?

I think you should go ahead and commit this, but add a warning in the issue when
you resolve it that we're considering alternatives. Then we can think about it
when we have more time.