Issue 10914200: Fix closing of server sockets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10914200: Fix closing of server sockets. (Closed)

Created:
8 years, 3 months ago by Mads Ager (google)

Modified:
8 years, 3 months ago

Reviewers:
Søren Gjesse, Anders Johnsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix closing of server sockets. Waiting for the onClosed event on the socket output stream is the right thing to do. However, only if we actually make sure that it will always close. :-) R=sgjesse@google.com,ajohnsen@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=12199

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review comments #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -2 lines)			Patch
	M	runtime/bin/http_impl.dart	View	1	3 chunks	+10 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

LGTM, thank you so much Mads! https://chromiumcodereview.appspot.com/10914200/diff/1/runtime/bin/http_impl.dart File runtime/bin/http_impl.dart (right): https://chromiumcodereview.appspot.com/10914200/diff/1/runtime/bin/http_impl.dart#newcode1360 runtime/bin/http_impl.dart:1360: if (_response == ...

8 years, 3 months ago (2012-09-11 12:49:40 UTC) #2

Mads Ager (google)

8 years, 3 months ago (2012-09-11 14:43:11 UTC) #4

https://chromiumcodereview.appspot.com/10914200/diff/1/runtime/bin/http_impl....
File runtime/bin/http_impl.dart (right):

https://chromiumcodereview.appspot.com/10914200/diff/1/runtime/bin/http_impl....
runtime/bin/http_impl.dart:1360: if (_response == null) _close();
On 2012/09/11 12:49:40, ajohnsen wrote:
> Nice. Would it make sense to move this to below the onClosed assignment?

I can do that. Thanks. :)

Expand Messages | Collapse Messages