Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 10914129: Remove proxying support from dart:html (Closed)

Created:
8 years, 3 months ago by vsm
Modified:
8 years, 3 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove proxying support from dart:html I'm moving this functionality to a user-level library. Committed: https://code.google.com/p/dart/source/detail?r=11997

Patch Set 1 #

Patch Set 2 : Regen dart:html #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1142 lines) Patch
M client/dart.js View 5 chunks +6 lines, -188 lines 0 comments Download
M lib/html/dart2js/html_dart2js.dart View 3 chunks +0 lines, -219 lines 0 comments Download
M lib/html/dartium/html_dartium.dart View 3 chunks +0 lines, -219 lines 0 comments Download
M lib/html/src/Isolates.dart View 3 chunks +0 lines, -219 lines 0 comments Download
M tests/html/html.status View 2 chunks +0 lines, -8 lines 0 comments Download
D tests/html/js_interop_element_test.dart View 1 chunk +0 lines, -61 lines 0 comments Download
D tests/html/js_interop_func_passing_test.dart View 1 chunk +0 lines, -97 lines 0 comments Download
D tests/html/js_interop_obj_invoke_test.dart View 1 chunk +0 lines, -51 lines 0 comments Download
D tests/html/js_interop_obj_passing_test.dart View 1 chunk +0 lines, -80 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
vsm
8 years, 3 months ago (2012-09-06 21:47:44 UTC) #1
Emily Fortuna
lgtm... is this code actually being added back anywhere or does this CL just delete ...
8 years, 3 months ago (2012-09-06 22:23:14 UTC) #2
vsm
8 years, 3 months ago (2012-09-06 22:24:40 UTC) #3
On 2012/09/06 22:23:14, Emily Fortuna wrote:
> lgtm... is this code actually being added back anywhere or does this CL just
> delete it all?

A significantly modified version will be added back as a user lib in a later CL.

Powered by Google App Engine
This is Rietveld 408576698