Issue 10914093: Cleanup in http_utils.dart.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10914093: Cleanup in http_utils.dart. (Closed)

Created:
8 years, 3 months ago by Anders Johnsen

Modified:
8 years, 3 months ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Cleanup in http_utils.dart. Followup fixes to ager's DBC. BUG= Committed: https://code.google.com/p/dart/source/detail?r=11863

Patch Set 2 : Mark declaration type as const as well. #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -16 lines)			Patch
	M	runtime/bin/http_utils.dart	View	1	4 chunks	+22 lines, -16 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

lgtm https://chromiumcodereview.appspot.com/10914093/diff/1/runtime/bin/http_utils.dart File runtime/bin/http_utils.dart (right): https://chromiumcodereview.appspot.com/10914093/diff/1/runtime/bin/http_utils.dart#newcode97 runtime/bin/http_utils.dart:97: List wkday = const ["Mon", "Tue", "Wed", "Thu", ...

8 years, 3 months ago (2012-09-05 08:52:51 UTC) #2

Anders Johnsen

8 years, 3 months ago (2012-09-05 09:09:46 UTC) #3

Landing.

https://chromiumcodereview.appspot.com/10914093/diff/1/runtime/bin/http_utils...
File runtime/bin/http_utils.dart (right):

https://chromiumcodereview.appspot.com/10914093/diff/1/runtime/bin/http_utils...
runtime/bin/http_utils.dart:97: List wkday = const ["Mon", "Tue", "Wed", "Thu",
"Fri", "Sat", "Sun"];
On 2012/09/05 08:52:51, Mads Ager wrote:
> Mark the wkday as const as well?
> 
> const List wkday = const [...];
> 
> ?

Got'ya, done.

Expand Messages | Collapse Messages

Issue 10914093: Cleanup in http_utils.dart. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Mark declaration type as const as well. #

Messages