Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 10913214: Move VM specific library files to the runtime/lib directory so they do (Closed)

Created:
8 years, 3 months ago by Mads Ager (google)
Modified:
8 years, 3 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Move VM specific library files to the runtime/lib directory so they do not become part of the SDK. We should get rid of these files and use the real library file that sources the rest of the implementation. That work is tracked in dartbug.com/5099. R=iposva@google.com BUG=dartbug.com/5069 Committed: https://code.google.com/p/dart/source/detail?r=12240

Patch Set 1 #

Patch Set 2 : Fix comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -135 lines) Patch
D lib/crypto/crypto_vm.dart View 1 chunk +0 lines, -127 lines 0 comments Download
D lib/utf/utf_vm.dart View 1 chunk +0 lines, -8 lines 0 comments Download
M runtime/bin/crypto_sources.gypi View 1 chunk +5 lines, -1 line 0 comments Download
M runtime/bin/utf_sources.gypi View 1 1 chunk +5 lines, -1 line 0 comments Download
A + runtime/lib/crypto/crypto_vm.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/lib/utf/utf_vm.dart View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (google)
8 years, 3 months ago (2012-09-12 07:31:01 UTC) #1
Ivan Posva
8 years, 3 months ago (2012-09-12 07:34:59 UTC) #2
LGTM -ip

Powered by Google App Engine
This is Rietveld 408576698