Issue 10913176: Reject non-ASCII identifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10913176: Reject non-ASCII identifiers. (Closed)

Created:
8 years, 3 months ago by ahe

Modified:
8 years, 3 months ago

Reviewers:
Lasse Reichstein Nielsen, ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Reject non-ASCII identifiers. Also change error handling in the scanner. Committed: https://code.google.com/p/dart/source/detail?r=12175

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -59 lines)			Patch
M	dart/lib/compiler/implementation/scanner/array_based_scanner.dart	View	2 chunks	+4 lines, -5 lines	0 comments	Download
M	dart/lib/compiler/implementation/scanner/scanner.dart	View	9 chunks	+17 lines, -25 lines	0 comments	Download
M	dart/lib/compiler/implementation/scanner/scanner_task.dart	View	1 chunk	+1 line, -14 lines	0 comments	Download
M	dart/lib/compiler/implementation/scanner/token.dart	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	dart/lib/compiler/implementation/tools/mini_parser.dart	View	2 chunks	+1 line, -13 lines	0 comments	Download
M	dart/tests/co19/co19-dart2js.status	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ahe

On 2012/09/11 09:00:38, ngeoffray wrote: > So where in the code is the bad input ...

8 years, 3 months ago (2012-09-11 09:01:35 UTC) #4

ngeoffray

8 years, 3 months ago (2012-09-11 09:03:53 UTC) #5

On 2012/09/11 09:01:35, ahe wrote:
> On 2012/09/11 09:00:38, ngeoffray wrote:
> > So where in the code is the bad input reported now?
> 
> It is reported by the parser. Bad input is an unexpected token.

OK. Change LGTM

Expand Messages | Collapse Messages