Issue 5004. Type inference with 'is!' and 'continue'.

Issue 5004. Type inference with 'is!' and 'continue'.
http://code.google.com/p/dart/issues/detail?id=5004


R=brianwilkerson@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=12123

[Brian Wilkerson, 2012-09-10 15:27:06]

https://chromiumcodereview.appspot.com/10913168/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java (right):

https://chromiumcodereview.appspot.com/10913168/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java:835: return true;
Does "L: while(...) { continue L; }" exit the loop? I would have said not.

https://chromiumcodereview.appspot.com/10913168/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java:838: return true;
What about break statements within switch statements?

[scheglov, 2012-09-10 15:38:11]

https://chromiumcodereview.appspot.com/10913168/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java (right):

https://chromiumcodereview.appspot.com/10913168/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java:835: return true;
On 2012/09/10 15:27:06, Brian Wilkerson wrote:
> Does "L: while(...) { continue L; }" exit the loop? I would have said not.

Well, it is not exit from the loop, but it is "exit" from the loop body, because
it stops execution of the loop body.

https://chromiumcodereview.appspot.com/10913168/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java:838: return true;
On 2012/09/10 15:27:06, Brian Wilkerson wrote:
> What about break statements within switch statements?

No opinion.
Just not covered by this CL.
This looks safe for me, we will not infer anything more by not handling switch.

[Brian Wilkerson, 2012-09-10 15:42:50]

LGTM

https://chromiumcodereview.appspot.com/10913168/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java (right):

https://chromiumcodereview.appspot.com/10913168/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java:838: return true;
> This looks safe for me, we will not infer anything more by not handling
switch.

Never mind. I understand now. We're not looking inside switch statements, so
there's no possibility of confusion.