Issue 10913153: Parse methods named 'get' or 'set'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10913153: Parse methods named 'get' or 'set' (Closed)

Created:
8 years, 3 months ago by ahe

Modified:
8 years, 3 months ago

Reviewers:
aam-me, ngeoffray

CC:
reviews_dartlang.org, Lasse Reichstein Nielsen

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Parse methods named 'get' or 'set'. Committed: https://code.google.com/p/dart/source/detail?r=12143

Patch Set 2 : Store type annotations #

Total comments: 2

Patch Set 3 : Address review comments #

Patch Set 5 : Rebased #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+138 lines, -60 lines)			Patch
M	dart/lib/compiler/implementation/resolver.dart	View	1 2 3 4	1 chunk	+2 lines, -0 lines	0 comments	Download
M	dart/lib/compiler/implementation/scanner/listener.dart	View	1 2 3 4	4 chunks	+6 lines, -2 lines	0 comments	Download
M	dart/lib/compiler/implementation/scanner/parser.dart	View	1 2 3 4	6 chunks	+112 lines, -50 lines	0 comments	Download
M	dart/tests/co19/co19-dart2js.status	View	1 2 3 4	2 chunks	+2 lines, -5 lines	0 comments	Download
M	dart/tests/language/language_dart2js.status	View	1	2 chunks	+16 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM! https://chromiumcodereview.appspot.com/10913153/diff/5001/dart/lib/compiler/implementation/scanner/parser.dart File dart/lib/compiler/implementation/scanner/parser.dart (right): https://chromiumcodereview.appspot.com/10913153/diff/5001/dart/lib/compiler/implementation/scanner/parser.dart#newcode516 dart/lib/compiler/implementation/scanner/parser.dart:516: if (optional('operator', identifiers.head)) { 'operator' does not apply ...

8 years, 3 months ago (2012-09-10 14:24:49 UTC) #2

ahe

8 years, 3 months ago (2012-09-10 19:03:02 UTC) #3

Thank you, Nicolas!

https://chromiumcodereview.appspot.com/10913153/diff/5001/dart/lib/compiler/i...
File dart/lib/compiler/implementation/scanner/parser.dart (right):

https://chromiumcodereview.appspot.com/10913153/diff/5001/dart/lib/compiler/i...
dart/lib/compiler/implementation/scanner/parser.dart:516: if
(optional('operator', identifiers.head)) {
On 2012/09/10 14:24:49, ngeoffray wrote:
> 'operator' does not apply to top level methods.

Done.