VM can parse and ignore metadata

VM can parse and ignore metadata

Support parsing of metadata in all legal locations except library
and import directives. The metadata is simply ignored. It is not
evaluated or validated for correctness.
 
Committed: https://code.google.com/p/dart/source/detail?r=12078

[siva, 2012-09-07 22:30:17]

lgtm

http://codereview.chromium.org/10913138/diff/9/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

http://codereview.chromium.org/10913138/diff/9/runtime/vm/parser.cc#newcode4912
runtime/vm/parser.cc:4912: // Not a legal type identifier or const keyword or
metadata
missing '.'

http://codereview.chromium.org/10913138/diff/9/tests/language/metadata_test.dart
File tests/language/metadata_test.dart (right):

http://codereview.chromium.org/10913138/diff/9/tests/language/metadata_test.d...
tests/language/metadata_test.dart:20: @meta1 typedef int DingDong<@meta2
T>(@meta1 event);
We probably need some cases which exercise the id.id.id path
i.e

@class.func.var
@class.func

http://codereview.chromium.org/10913138/diff/9/tests/language/metadata_test.d...
tests/language/metadata_test.dart:40: }
How about:

 @raw_string var string = @'this is a \\ raw string.'

[hausner, 2012-09-07 23:07:24]

Thank you.

http://codereview.chromium.org/10913138/diff/9/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

http://codereview.chromium.org/10913138/diff/9/runtime/vm/parser.cc#newcode4912
runtime/vm/parser.cc:4912: // Not a legal type identifier or const keyword or
metadata
On 2012/09/07 22:30:17, asiva wrote:
> missing '.'

Done.

http://codereview.chromium.org/10913138/diff/9/tests/language/metadata_test.dart
File tests/language/metadata_test.dart (right):

http://codereview.chromium.org/10913138/diff/9/tests/language/metadata_test.d...
tests/language/metadata_test.dart:20: @meta1 typedef int DingDong<@meta2
T>(@meta1 event);
The form with 3 identifiers refers to a qualified name that is imported. I added
a library and test cases for this form too.

On 2012/09/07 22:30:17, asiva wrote:
> We probably need some cases which exercise the id.id.id path
> i.e
> 
> @class.func.var
> @class.func

http://codereview.chromium.org/10913138/diff/9/tests/language/metadata_test.d...
tests/language/metadata_test.dart:40: }
On 2012/09/07 22:30:17, asiva wrote:
> How about:
> 
>  @raw_string var string = @'this is a \\ raw string.'

Done.