Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 10913125: Remove lib/dom directory! (Closed)

Created:
8 years, 3 months ago by Emily Fortuna
Modified:
8 years, 3 months ago
Reviewers:
vsm, Anton Muhin
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove lib/dom directory! Committed: https://code.google.com/p/dart/source/detail?r=12082

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -19630 lines) Patch
D lib/dom/idl/dart/dart.idl View 1 1 chunk +0 lines, -349 lines 0 comments Download
D lib/dom/scripts/all_tests.py View 1 1 chunk +0 lines, -24 lines 0 comments Download
D lib/dom/scripts/dartdomgenerator.py View 1 1 chunk +0 lines, -147 lines 0 comments Download
D lib/dom/scripts/dartgenerator.py View 1 1 chunk +0 lines, -289 lines 0 comments Download
D lib/dom/scripts/dartgenerator_test.py View 1 1 chunk +0 lines, -238 lines 0 comments Download
D lib/dom/scripts/database.py View 1 1 chunk +0 lines, -236 lines 0 comments Download
D lib/dom/scripts/database_test.py View 1 1 chunk +0 lines, -93 lines 0 comments Download
D lib/dom/scripts/databasebuilder.py View 1 1 chunk +0 lines, -559 lines 0 comments Download
D lib/dom/scripts/databasebuilder_test.py View 1 1 chunk +0 lines, -387 lines 0 comments Download
D lib/dom/scripts/emitter.py View 1 1 chunk +0 lines, -217 lines 0 comments Download
D lib/dom/scripts/emitter_test.py View 1 1 chunk +0 lines, -100 lines 0 comments Download
D lib/dom/scripts/fremontcutbuilder.py View 1 1 chunk +0 lines, -217 lines 0 comments Download
D lib/dom/scripts/generator.py View 1 1 chunk +0 lines, -883 lines 0 comments Download
D lib/dom/scripts/go.sh View 1 1 chunk +0 lines, -53 lines 0 comments Download
D lib/dom/scripts/htmlrenamer.py View 1 1 chunk +0 lines, -312 lines 0 comments Download
D lib/dom/scripts/idlnode.py View 1 1 chunk +0 lines, -493 lines 0 comments Download
D lib/dom/scripts/idlnode_test.py View 1 1 chunk +0 lines, -147 lines 0 comments Download
D lib/dom/scripts/idlparser.dart View 1 1 chunk +0 lines, -549 lines 0 comments Download
D lib/dom/scripts/idlparser.py View 1 1 chunk +0 lines, -439 lines 0 comments Download
D lib/dom/scripts/idlparser_test.dart View 1 1 chunk +0 lines, -116 lines 0 comments Download
D lib/dom/scripts/idlparser_test.py View 1 1 chunk +0 lines, -159 lines 0 comments Download
D lib/dom/scripts/idlrenderer.dart View 1 1 chunk +0 lines, -180 lines 0 comments Download
D lib/dom/scripts/idlrenderer.py View 1 1 chunk +0 lines, -177 lines 0 comments Download
D lib/dom/scripts/idlrenderer_test.py View 1 1 chunk +0 lines, -83 lines 0 comments Download
D lib/dom/scripts/idlsync.py View 1 1 chunk +0 lines, -119 lines 0 comments Download
D lib/dom/scripts/logging.conf View 1 1 chunk +0 lines, -58 lines 0 comments Download
D lib/dom/scripts/multiemitter.py View 1 1 chunk +0 lines, -85 lines 0 comments Download
D lib/dom/scripts/multiemitter_test.py View 1 1 chunk +0 lines, -47 lines 0 comments Download
D lib/dom/scripts/pegparser.py View 1 1 chunk +0 lines, -527 lines 0 comments Download
D lib/dom/scripts/pegparser_test.py View 1 1 chunk +0 lines, -200 lines 0 comments Download
D lib/dom/scripts/systembase.py View 1 1 chunk +0 lines, -242 lines 0 comments Download
D lib/dom/scripts/systemhtml.py View 1 1 chunk +0 lines, -1242 lines 0 comments Download
D lib/dom/scripts/systeminterface.py View 1 1 chunk +0 lines, -200 lines 0 comments Download
D lib/dom/scripts/systemnative.py View 1 1 chunk +0 lines, -969 lines 0 comments Download
D lib/dom/scripts/templateloader.py View 1 1 chunk +0 lines, -116 lines 0 comments Download
D lib/dom/scripts/templateloader_test.py View 1 1 chunk +0 lines, -131 lines 0 comments Download
D lib/dom/src/DOMType.dart View 1 1 chunk +0 lines, -10 lines 0 comments Download
D lib/dom/src/EventListener.dart View 1 1 chunk +0 lines, -5 lines 0 comments Download
D lib/dom/src/GlobalProperties.dart View 1 1 chunk +0 lines, -21 lines 0 comments Download
D lib/dom/src/KeyLocation.dart View 1 1 chunk +0 lines, -45 lines 0 comments Download
D lib/dom/src/KeyName.dart View 1 1 chunk +0 lines, -493 lines 0 comments Download
D lib/dom/src/ReadyState.dart View 1 1 chunk +0 lines, -24 lines 0 comments Download
D lib/dom/src/Timer.dart View 1 1 chunk +0 lines, -28 lines 0 comments Download
D lib/dom/src/_Collections.dart View 1 1 chunk +0 lines, -52 lines 0 comments Download
D lib/dom/src/_FactoryProviders.dart View 1 1 chunk +0 lines, -103 lines 0 comments Download
D lib/dom/src/_HttpRequestUtils.dart View 1 1 chunk +0 lines, -28 lines 0 comments Download
D lib/dom/src/_ListIterators.dart View 1 1 chunk +0 lines, -33 lines 0 comments Download
D lib/dom/src/_Lists.dart View 1 1 chunk +0 lines, -68 lines 0 comments Download
D lib/dom/src/dart2js_DOMImplementation.dart View 1 1 chunk +0 lines, -62 lines 0 comments Download
D lib/dom/src/dart2js_DOMType.dart View 1 1 chunk +0 lines, -10 lines 0 comments Download
D lib/dom/src/dart2js_DOMTypeJs.dart View 1 1 chunk +0 lines, -10 lines 0 comments Download
D lib/dom/src/dart2js_FactoryProviders.dart View 1 1 chunk +0 lines, -30 lines 0 comments Download
D lib/dom/src/dart2js_IDBKeyRangeFactoryProvider.dart View 1 1 chunk +0 lines, -47 lines 0 comments Download
D lib/dom/src/dart2js_TypedArrayFactoryProvider.dart View 1 1 chunk +0 lines, -113 lines 0 comments Download
D lib/dom/src/dummy_FactoryProviders.dart View 1 1 chunk +0 lines, -71 lines 0 comments Download
D lib/dom/src/dummy_GlobalProperties.dart View 1 1 chunk +0 lines, -10 lines 0 comments Download
D lib/dom/src/native_DOMImplementation.dart View 1 1 chunk +0 lines, -114 lines 0 comments Download
D lib/dom/src/native_DOMPublic.dart View 1 1 chunk +0 lines, -29 lines 0 comments Download
D lib/dom/templates/callback.darttemplate View 1 1 chunk +0 lines, -7 lines 0 comments Download
D lib/dom/templates/dart2js_impl.darttemplate View 1 1 chunk +0 lines, -3 lines 0 comments Download
D lib/dom/templates/html/dart2js/factoryprovider.darttemplate View 1 1 chunk +0 lines, -8 lines 0 comments Download
D lib/dom/templates/html/dart2js/factoryprovider_AudioElement.darttemplate View 1 1 chunk +0 lines, -10 lines 0 comments Download
D lib/dom/templates/html/dart2js/factoryprovider_Blob.darttemplate View 1 1 chunk +0 lines, -24 lines 0 comments Download
D lib/dom/templates/html/dart2js/factoryprovider_CSSMatrix.darttemplate View 1 1 chunk +0 lines, -8 lines 0 comments Download
D lib/dom/templates/html/dart2js/factoryprovider_DataView.darttemplate View 1 1 chunk +0 lines, -13 lines 0 comments Download
D lib/dom/templates/html/dart2js/factoryprovider_FormData.darttemplate View 1 1 chunk +0 lines, -10 lines 0 comments Download
D lib/dom/templates/html/dart2js/factoryprovider_HttpRequest.darttemplate View 1 1 chunk +0 lines, -15 lines 0 comments Download
D lib/dom/templates/html/dart2js/factoryprovider_MutationObserver.darttemplate View 1 1 chunk +0 lines, -12 lines 0 comments Download
D lib/dom/templates/html/dart2js/factoryprovider_OptionElement.darttemplate View 1 1 chunk +0 lines, -15 lines 0 comments Download
D lib/dom/templates/html/dart2js/factoryprovider_ShadowRoot.darttemplate View 1 1 chunk +0 lines, -9 lines 0 comments Download
D lib/dom/templates/html/dart2js/factoryprovider_SharedWorker.darttemplate View 1 1 chunk +0 lines, -10 lines 0 comments Download
D lib/dom/templates/html/dart2js/factoryprovider_TextTrackCue.darttemplate View 1 1 chunk +0 lines, -14 lines 0 comments Download
D lib/dom/templates/html/dart2js/html_dart2js.darttemplate View 1 1 chunk +0 lines, -74 lines 0 comments Download
D lib/dom/templates/html/dart2js/impl_CanvasElement.darttemplate View 1 1 chunk +0 lines, -9 lines 0 comments Download
D lib/dom/templates/html/dart2js/impl_Console.darttemplate View 1 1 chunk +0 lines, -10 lines 0 comments Download
D lib/dom/templates/html/dart2js/impl_IDBDatabase.darttemplate View 1 1 chunk +0 lines, -51 lines 0 comments Download
D lib/dom/templates/html/dart2js/impl_IFrameElement.darttemplate View 1 1 chunk +0 lines, -14 lines 0 comments Download
D lib/dom/templates/html/dart2js/impl_MouseEvent.darttemplate View 1 1 chunk +0 lines, -38 lines 0 comments Download
D lib/dom/templates/html/dart2js/impl_Window.darttemplate View 1 1 chunk +0 lines, -140 lines 0 comments Download
D lib/dom/templates/html/dartium/cpp_callback_header.template View 1 1 chunk +0 lines, -46 lines 0 comments Download
D lib/dom/templates/html/dartium/cpp_callback_implementation.template View 1 1 chunk +0 lines, -14 lines 0 comments Download
D lib/dom/templates/html/dartium/cpp_derived_sources.template View 1 1 chunk +0 lines, -9 lines 0 comments Download
D lib/dom/templates/html/dartium/cpp_header.template View 1 1 chunk +0 lines, -39 lines 0 comments Download
D lib/dom/templates/html/dartium/cpp_implementation.template View 1 1 chunk +0 lines, -27 lines 0 comments Download
D lib/dom/templates/html/dartium/cpp_resolver.template View 1 1 chunk +0 lines, -18 lines 0 comments Download
D lib/dom/templates/html/dartium/dart_implementation.darttemplate View 1 1 chunk +0 lines, -9 lines 0 comments Download
D lib/dom/templates/html/dartium/factoryprovider.darttemplate View 1 1 chunk +0 lines, -8 lines 0 comments Download
D lib/dom/templates/html/dartium/factoryprovider_HttpRequest.darttemplate View 1 1 chunk +0 lines, -16 lines 0 comments Download
D lib/dom/templates/html/dartium/html_dartium.darttemplate View 1 1 chunk +0 lines, -86 lines 0 comments Download
D lib/dom/templates/html/dartium/impl_Window.darttemplate View 1 1 chunk +0 lines, -30 lines 0 comments Download
D lib/dom/templates/html/impl/factoryprovider_Elements.darttemplate View 1 1 chunk +0 lines, -7 lines 0 comments Download
D lib/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate View 1 1 chunk +0 lines, -2789 lines 0 comments Download
D lib/dom/templates/html/impl/impl_CanvasElement.darttemplate View 1 1 chunk +0 lines, -9 lines 0 comments Download
D lib/dom/templates/html/impl/impl_Document.darttemplate View 1 1 chunk +0 lines, -45 lines 0 comments Download
D lib/dom/templates/html/impl/impl_DocumentFragment.darttemplate View 1 1 chunk +0 lines, -361 lines 0 comments Download
D lib/dom/templates/html/impl/impl_Element.darttemplate View 1 1 chunk +0 lines, -882 lines 0 comments Download
D lib/dom/templates/html/impl/impl_EventTarget.darttemplate View 1 1 chunk +0 lines, -61 lines 0 comments Download
D lib/dom/templates/html/impl/impl_MutationObserver.darttemplate View 1 1 chunk +0 lines, -78 lines 0 comments Download
D lib/dom/templates/html/impl/impl_Node.darttemplate View 1 1 chunk +0 lines, -146 lines 0 comments Download
D lib/dom/templates/html/impl/impl_NodeList.darttemplate View 1 1 chunk +0 lines, -173 lines 0 comments Download
D lib/dom/templates/html/impl/impl_SVGElement.darttemplate View 1 1 chunk +0 lines, -54 lines 0 comments Download
D lib/dom/templates/html/impl/impl_Storage.darttemplate View 1 1 chunk +0 lines, -54 lines 0 comments Download
D lib/dom/templates/html/interface/interface.darttemplate View 1 1 chunk +0 lines, -9 lines 0 comments Download
D lib/dom/templates/html/interface/interface_AudioContext.darttemplate View 1 1 chunk +0 lines, -10 lines 0 comments Download
D lib/dom/templates/html/interface/interface_CSSStyleDeclaration.darttemplate View 1 1 chunk +0 lines, -1855 lines 0 comments Download
D lib/dom/templates/html/interface/interface_CanvasElement.darttemplate View 1 1 chunk +0 lines, -11 lines 0 comments Download
D lib/dom/templates/html/interface/interface_Document.darttemplate View 1 1 chunk +0 lines, -9 lines 0 comments Download
D lib/dom/templates/html/interface/interface_DocumentFragment.darttemplate View 1 1 chunk +0 lines, -21 lines 0 comments Download
D lib/dom/templates/html/interface/interface_Element.darttemplate View 1 1 chunk +0 lines, -117 lines 0 comments Download
D lib/dom/templates/html/interface/interface_Event.darttemplate View 1 1 chunk +0 lines, -17 lines 0 comments Download
D lib/dom/templates/html/interface/interface_EventTarget.darttemplate View 1 1 chunk +0 lines, -25 lines 0 comments Download
D lib/dom/templates/html/interface/interface_HttpRequest.darttemplate View 1 1 chunk +0 lines, -12 lines 0 comments Download
D lib/dom/templates/html/interface/interface_IDBKeyRange.darttemplate View 1 1 chunk +0 lines, -31 lines 0 comments Download
D lib/dom/templates/html/interface/interface_MouseEvent.darttemplate View 1 1 chunk +0 lines, -15 lines 0 comments Download
D lib/dom/templates/html/interface/interface_MutationObserver.darttemplate View 1 1 chunk +0 lines, -19 lines 0 comments Download
D lib/dom/templates/html/interface/interface_Node.darttemplate View 1 1 chunk +0 lines, -26 lines 0 comments Download
D lib/dom/templates/html/interface/interface_NodeList.darttemplate View 1 1 chunk +0 lines, -17 lines 0 comments Download
D lib/dom/templates/html/interface/interface_NodeSelector.darttemplate View 1 1 chunk +0 lines, -14 lines 0 comments Download
D lib/dom/templates/html/interface/interface_Point.darttemplate View 1 1 chunk +0 lines, -11 lines 0 comments Download
D lib/dom/templates/html/interface/interface_SVGElement.darttemplate View 1 1 chunk +0 lines, -14 lines 0 comments Download
D lib/dom/templates/html/interface/interface_SVGSVGElement.darttemplate View 1 1 chunk +0 lines, -11 lines 0 comments Download
D lib/dom/templates/html/interface/interface_Storage.darttemplate View 1 1 chunk +0 lines, -8 lines 0 comments Download
D lib/dom/templates/html/interface/interface_Text.darttemplate View 1 1 chunk +0 lines, -11 lines 0 comments Download
D lib/dom/templates/html/interface/interface_WebSocket.darttemplate View 1 1 chunk +0 lines, -11 lines 0 comments Download
D lib/dom/templates/html/interface/interface_Window.darttemplate View 1 1 chunk +0 lines, -49 lines 0 comments Download
D lib/dom/templates/immutable_list_mixin.darttemplate View 1 1 chunk +0 lines, -76 lines 0 comments Download
D lib/dom/templates/interface.darttemplate View 1 1 chunk +0 lines, -8 lines 0 comments Download
M + lib/html/idl/dart/dart.idl View 1 1 chunk +5 lines, -0 lines 0 comments Download
A + lib/html/scripts/all_tests.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/html/scripts/dartdomgenerator.py View 1 3 chunks +6 lines, -6 lines 0 comments Download
A + lib/html/scripts/dartgenerator.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/html/scripts/dartgenerator_test.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/html/scripts/database.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/html/scripts/database_test.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/html/scripts/databasebuilder.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/html/scripts/databasebuilder_test.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/html/scripts/emitter.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/html/scripts/emitter_test.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/html/scripts/fremontcutbuilder.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/html/scripts/generator.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/html/scripts/go.sh View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/html/scripts/htmlrenamer.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/html/scripts/idlnode.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/html/scripts/idlnode_test.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/html/scripts/idlparser.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/html/scripts/idlparser.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/html/scripts/idlparser_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/html/scripts/idlparser_test.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/html/scripts/idlrenderer.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/html/scripts/idlrenderer.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/html/scripts/idlrenderer_test.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/html/scripts/idlsync.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A lib/html/scripts/logging.conf View 1 chunk +58 lines, -0 lines 1 comment Download
A + lib/html/scripts/multiemitter.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/html/scripts/multiemitter_test.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/html/scripts/pegparser.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/html/scripts/pegparser_test.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/html/scripts/systembase.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/html/scripts/systemhtml.py View 1 1 chunk +1 line, -0 lines 0 comments Download
A + lib/html/scripts/systeminterface.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/html/scripts/systemnative.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/html/scripts/templateloader.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/html/scripts/templateloader_test.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/html/src/EventListener.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/html/src/KeyLocation.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/html/src/KeyName.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/html/src/ReadyState.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/html/src/Timer.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/html/src/_Collections.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/html/src/_HttpRequestUtils.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/html/src/_ListIterators.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/html/src/_Lists.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/html/src/dart2js_TypedArrayFactoryProvider.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/html/src/native_DOMImplementation.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/html/src/native_DOMPublic.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M + lib/html/templates/html/dart2js/html_dart2js.darttemplate View 1 2 chunks +10 lines, -10 lines 0 comments Download
M + lib/html/templates/html/dartium/html_dartium.darttemplate View 1 2 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Emily Fortuna
This should completely remove lib/dom with the exception of lib/html/templates/dom/native, which we can remove when ...
8 years, 3 months ago (2012-09-07 00:28:32 UTC) #1
Emily Fortuna
+Anton to look at as well. @vsm, antonm, please look at my message in the ...
8 years, 3 months ago (2012-09-07 00:30:11 UTC) #2
podivilov
On 2012/09/07 00:30:11, Emily Fortuna wrote: > +Anton to look at as well. > @vsm, ...
8 years, 3 months ago (2012-09-07 10:25:04 UTC) #3
Emily Fortuna
PTAL. This is identical to my previous version with the exception that I did NOT ...
8 years, 3 months ago (2012-09-07 21:37:42 UTC) #4
vsm
8 years, 3 months ago (2012-09-07 23:49:27 UTC) #5
lgtm!

https://chromiumcodereview.appspot.com/10913125/diff/4022/lib/html/scripts/lo...
File lib/html/scripts/logging.conf (right):

https://chromiumcodereview.appspot.com/10913125/diff/4022/lib/html/scripts/lo...
lib/html/scripts/logging.conf:2:
keys=root,pegparser,database,databasebuilder,dartgenerator,snippet_manager,w3cscraper
I think w3cscrapper can go (here and below) - that's an old file.

Powered by Google App Engine
This is Rietveld 408576698