Issue 10913077: Use a bare git repository for the repo cache.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10913077: Use a bare git repository for the repo cache. (Closed)

Created:
8 years, 3 months ago by nweiz

Modified:
8 years, 3 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Use a bare git repository for the repo cache. This also allows remote branch names to be used in the `ref` field for Git dependencies. BUG=4892 Committed: https://code.google.com/p/dart/source/detail?r=11856

Patch Set 1 #

Total comments: 4

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+78 lines, -23 lines)			Patch
M	utils/pub/git_source.dart	View	3 chunks	+9 lines, -5 lines	4 comments	Download
M	utils/tests/pub/pub_install_git_test.dart	View	7 chunks	+42 lines, -15 lines	0 comments	Download
M	utils/tests/pub/test_pub.dart	View	4 chunks	+27 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

LGTM https://chromiumcodereview.appspot.com/10913077/diff/1/utils/pub/git_source.dart File utils/pub/git_source.dart (right): https://chromiumcodereview.appspot.com/10913077/diff/1/utils/pub/git_source.dart#newcode130 utils/pub/git_source.dart:130: print(result.stderr); Remove these. https://chromiumcodereview.appspot.com/10913077/diff/1/utils/pub/git_source.dart#newcode159 utils/pub/git_source.dart:159: * Clones the ...

8 years, 3 months ago (2012-09-05 00:56:04 UTC) #2

nweiz

8 years, 3 months ago (2012-09-05 21:10:42 UTC) #3

https://chromiumcodereview.appspot.com/10913077/diff/1/utils/pub/git_source.dart
File utils/pub/git_source.dart (right):

https://chromiumcodereview.appspot.com/10913077/diff/1/utils/pub/git_source.d...
utils/pub/git_source.dart:130: print(result.stderr);
On 2012/09/05 00:56:04, Bob Nystrom wrote:
> Remove these.

Done.

https://chromiumcodereview.appspot.com/10913077/diff/1/utils/pub/git_source.d...
utils/pub/git_source.dart:159: * Clones the repo at the URI [from] to the path
[to] on the local filesystem.
On 2012/09/05 00:56:04, Bob Nystrom wrote:
> Can you explain what "mirror" is for here?

Done.

Expand Messages | Collapse Messages