Issue 10913067: Simplify Unparser.unparseClassWithBody.

Issue 10913067: Simplify Unparser.unparseClassWithBody. (Closed)

Created:
8 years, 3 months ago by Anton Muhin

Modified:
8 years, 3 months ago

Reviewers:
Roman

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Simplify Unparser.unparseClassWithBody. R=smok@google.com Committed: https://code.google.com/p/dart/source/detail?r=11831

Patch Set 1 #

Total comments: 4

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -81 lines)			Patch
M	lib/compiler/implementation/dart_backend/emitter.dart	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	lib/compiler/implementation/tree/unparser.dart	View	2 chunks	+5 lines, -15 lines	4 comments	Download
M	tests/compiler/dart2js/unparser2_test.dart	View	2 chunks	+8 lines, -62 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Roman

lgtm https://chromiumcodereview.appspot.com/10913067/diff/1/lib/compiler/implementation/tree/unparser.dart File lib/compiler/implementation/tree/unparser.dart (right): https://chromiumcodereview.appspot.com/10913067/diff/1/lib/compiler/implementation/tree/unparser.dart#newcode64 lib/compiler/implementation/tree/unparser.dart:64: unparseClassWithBody(ClassNode node, Iterable<Node> members) { thank you for ...

8 years, 3 months ago (2012-09-04 17:12:15 UTC) #2

Anton Muhin

8 years, 3 months ago (2012-09-04 18:00:39 UTC) #3

https://chromiumcodereview.appspot.com/10913067/diff/1/lib/compiler/implement...
File lib/compiler/implementation/tree/unparser.dart (right):

https://chromiumcodereview.appspot.com/10913067/diff/1/lib/compiler/implement...
lib/compiler/implementation/tree/unparser.dart:64:
unparseClassWithBody(ClassNode node, Iterable<Node> members) {
On 2012/09/04 17:12:15, Roman wrote:
> thank you for specifying type :)

My pleasure

https://chromiumcodereview.appspot.com/10913067/diff/1/lib/compiler/implement...
lib/compiler/implementation/tree/unparser.dart:94: unparseClassWithBody(node,
node.body.nodes);
Not quite, but so far tests revealed no such cases, so let's be optimistic
here---that should be trivial to fix if need be.

On 2012/09/04 17:12:15, Roman wrote:
> original code performed null check on body. Are you sure that it can never be
> null?

Expand Messages | Collapse Messages