Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 10913060: Update status file to fix tests that are now passing because of FF on windows update. (Closed)

Created:
8 years, 3 months ago by ricow1
Modified:
8 years, 3 months ago
Reviewers:
ngeoffray, kasperl
CC:
reviews_dartlang.org, Emily Fortuna
Visibility:
Public.

Description

Update status file to fix tests that are now passing because of FF on windows update. FF was apparently updated to version 15 on the Windows buildbot. I have created 4896 make sure we have a consistent platform accross our bots. Committed: https://code.google.com/p/dart/source/detail?r=11791

Patch Set 1 #

Total comments: 5

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M tests/html/html.status View 1 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
ricow1
8 years, 3 months ago (2012-09-04 06:21:10 UTC) #1
kasperl
LGTM. Thanks a lot, Rico! https://chromiumcodereview.appspot.com/10913060/diff/1/tests/html/html.status File tests/html/html.status (right): https://chromiumcodereview.appspot.com/10913060/diff/1/tests/html/html.status#newcode155 tests/html/html.status:155: typed_arrays_dataview_test: Fail # DataView ...
8 years, 3 months ago (2012-09-04 07:08:04 UTC) #2
ngeoffray
https://chromiumcodereview.appspot.com/10913060/diff/1/tests/html/html.status File tests/html/html.status (right): https://chromiumcodereview.appspot.com/10913060/diff/1/tests/html/html.status#newcode155 tests/html/html.status:155: typed_arrays_dataview_test: Fail # DataView not implemented until Firefox 15.0. ...
8 years, 3 months ago (2012-09-04 07:14:51 UTC) #3
kasperl
https://chromiumcodereview.appspot.com/10913060/diff/1/tests/html/html.status File tests/html/html.status (right): https://chromiumcodereview.appspot.com/10913060/diff/1/tests/html/html.status#newcode155 tests/html/html.status:155: typed_arrays_dataview_test: Fail # DataView not implemented until Firefox 15.0. ...
8 years, 3 months ago (2012-09-04 07:17:34 UTC) #4
ricow1
https://chromiumcodereview.appspot.com/10913060/diff/1/tests/html/html.status File tests/html/html.status (right): https://chromiumcodereview.appspot.com/10913060/diff/1/tests/html/html.status#newcode155 tests/html/html.status:155: typed_arrays_dataview_test: Fail # DataView not implemented until Firefox 15.0. ...
8 years, 3 months ago (2012-09-04 07:23:33 UTC) #5
ricow1
8 years, 3 months ago (2012-09-04 07:24:54 UTC) #6
CC efortuna since I put her on the bug for the FF version mismatch

Powered by Google App Engine
This is Rietveld 408576698