Issue 10913031: Split deopt-after and deopt-before handling:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10913031: Split deopt-after and deopt-before handling: (Closed)

Created:
8 years, 3 months ago by srdjan

Modified:
8 years, 3 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Split deopt-after and deopt-before handling: - deopt-before describes a deoptimization that occurs before the instructionhas completed and requires a stub - deopt-after describes deoptimziation after the instruction, used by lazy deooptimization, requires no stub. Committed: https://code.google.com/p/dart/source/detail?r=11720

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+175 lines, -78 lines)			Patch
M	runtime/vm/deopt_instructions.h	View	1 2 3	2 chunks	+12 lines, -5 lines	0 comments	Download
M	runtime/vm/deopt_instructions.cc	View	1 2 3	5 chunks	+65 lines, -13 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler.h	View	1 2 3	2 chunks	+43 lines, -15 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler.cc	View	1 2 3	7 chunks	+31 lines, -15 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.h	View	1 2 3	4 chunks	+5 lines, -8 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View	1 2 3	2 chunks	+7 lines, -7 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.h	View	1 2 3	4 chunks	+5 lines, -8 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1 2 3	2 chunks	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://chromiumcodereview.appspot.com/10913031/diff/10002/runtime/vm/flow_graph_compiler.h File runtime/vm/flow_graph_compiler.h (right): https://chromiumcodereview.appspot.com/10913031/diff/10002/runtime/vm/flow_graph_compiler.h#newcode60 runtime/vm/flow_graph_compiler.h:60: // Used for describing a deoptimization point after ...

8 years, 3 months ago (2012-08-31 20:08:50 UTC) #2

srdjan

8 years, 3 months ago (2012-08-31 20:18:43 UTC) #3

https://chromiumcodereview.appspot.com/10913031/diff/10002/runtime/vm/flow_gr...
File runtime/vm/flow_graph_compiler.h (right):

https://chromiumcodereview.appspot.com/10913031/diff/10002/runtime/vm/flow_gr...
runtime/vm/flow_graph_compiler.h:60: // Used for describing a deoptimization
point after call (lazy deoptimziation).
On 2012/08/31 20:08:50, regis wrote:
> typo: deoptimziation

Done.

Expand Messages | Collapse Messages