Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 10913005: Better handling of reading empty files (Closed)

Created:
8 years, 3 months ago by Søren Gjesse
Modified:
8 years, 3 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Better handling of reading empty files R=whesse@google.com BUG=dart:4834 TEST=tests/standalone/io/file_test.dart Committed: https://code.google.com/p/dart/source/detail?r=11605

Patch Set 1 #

Patch Set 2 : Changed the aproach slightly #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -0 lines) Patch
M runtime/bin/file_impl.dart View 1 3 chunks +5 lines, -1 line 0 comments Download
A + runtime/tests/vm/data/empty_file View 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/standalone/io/file_test.dart View 5 chunks +43 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Gjesse
8 years, 3 months ago (2012-08-30 08:59:42 UTC) #1
Bill Hesse
8 years, 3 months ago (2012-08-30 10:20:28 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698