Issue 10912147: Change our 'is int' check to use Math.floor instead of a smi check.

Issue 10912147: Change our 'is int' check to use Math.floor instead of a smi check. (Closed)

Created:
8 years, 3 months ago by ngeoffray

Modified:
8 years, 3 months ago

Reviewers:
floitsch, kasperl

CC:
reviews_dartlang.org, Alan Knight

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Change our 'is int' check to use Math.floor instead of a smi check. Committed: https://code.google.com/p/dart/source/detail?r=12018

Patch Set 2 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -244 lines)			Patch
M	lib/compiler/implementation/lib/js_helper.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/compiler/implementation/ssa/codegen.dart	View	1	2 chunks	+14 lines, -1 line	0 comments	Download
M	pkg/intl/number_format.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/pkg.status	View	1	1 chunk	+2 lines, -29 lines	0 comments	Download
M	samples/tests/samples/samples.status	View	1	1 chunk	+0 lines, -9 lines	0 comments	Download
M	tests/co19/co19-dart2js.status	View	1	4 chunks	+1 line, -69 lines	0 comments	Download
M	tests/html/html.status	View	1	1 chunk	+2 lines, -87 lines	0 comments	Download
M	tests/isolate/isolate.status	View	1	1 chunk	+0 lines, -27 lines	0 comments	Download
M	tests/json/json.status	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
A	tests/language/infinity_test.dart	View	1	1 chunk	+15 lines, -0 lines	0 comments	Download
M	tests/language/language_dart2js.status	View	1	2 chunks	+1 line, -1 line	0 comments	Download
M	tests/lib/lib.status	View	1	1 chunk	+0 lines, -8 lines	0 comments	Download
M	tests/standalone/standalone.status	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	tests/utils/utils.status	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
M	utils/tests/pub/pub.status	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. Please add a failing test for infinity. https://chromiumcodereview.appspot.com/10912147/diff/1/lib/compiler/implementation/ssa/codegen.dart File lib/compiler/implementation/ssa/codegen.dart (right): https://chromiumcodereview.appspot.com/10912147/diff/1/lib/compiler/implementation/ssa/codegen.dart#newcode2158 lib/compiler/implementation/ssa/codegen.dart:2158: // ...

8 years, 3 months ago (2012-09-07 11:56:47 UTC) #3

ngeoffray

Thanks Kasper and Florian https://chromiumcodereview.appspot.com/10912147/diff/1/lib/compiler/implementation/ssa/codegen.dart File lib/compiler/implementation/ssa/codegen.dart (right): https://chromiumcodereview.appspot.com/10912147/diff/1/lib/compiler/implementation/ssa/codegen.dart#newcode2158 lib/compiler/implementation/ssa/codegen.dart:2158: // TODO(ngeoffray,floitsch): Deal with infinity. ...

8 years, 3 months ago (2012-09-07 12:06:26 UTC) #4

ngeoffray

8 years, 3 months ago (2012-09-07 12:51:42 UTC) #5

+alan, to let him know about the change to dart2js and the number formatting as
well.

Expand Messages | Collapse Messages