Issue 10912120: Restoring assert that deopt_id() should be accessed only if the instruction can deoptimize. Print r…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10912120: Restoring assert that deopt_id() should be accessed only if the instruction can deoptimize. Print r… (Closed)

Created:
8 years, 3 months ago by srdjan

Modified:
8 years, 3 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Restoring assert that deopt_id() should be accessed only if the instruction can deoptimize. Print resulting ssa_temp_indexes if available. Add an IL printing helper. Committed: https://code.google.com/p/dart/source/detail?r=11941

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -9 lines)			Patch
M	runtime/vm/il_printer.h	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/il_printer.cc	View	1 2 3	5 chunks	+14 lines, -5 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1 2 3	2 chunks	+7 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages