Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 10912109: Fix checked mode on browser. (Closed)

Created:
8 years, 3 months ago by ngeoffray
Modified:
8 years, 3 months ago
Reviewers:
ahe, floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix checked mode on browser. Committed: https://code.google.com/p/dart/source/detail?r=11933

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 1

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -571 lines) Patch
M lib/compiler/implementation/js_backend/native_emitter.dart View 1 2 chunks +6 lines, -1 line 0 comments Download
M pkg/pkg.status View 1 1 chunk +0 lines, -14 lines 0 comments Download
M samples/tests/samples/samples.status View 1 2 3 4 5 1 chunk +2 lines, -6 lines 0 comments Download
M tests/benchmark_smoke/benchmark_smoke.status View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/html.status View 1 2 3 4 1 chunk +4 lines, -86 lines 0 comments Download
M tests/isolate/isolate.status View 1 1 chunk +0 lines, -24 lines 0 comments Download
tests/json/json.status View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M tests/language/language_dart2js.status View 1 1 chunk +0 lines, -428 lines 0 comments Download
M tests/lib/lib.status View 1 1 chunk +0 lines, -3 lines 0 comments Download
M utils/compiler/buildbot.py View 1 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/pub/pub.status View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
ngeoffray
8 years, 3 months ago (2012-09-05 22:30:06 UTC) #1
ahe
LGTM, please also revert CL 10911107.
8 years, 3 months ago (2012-09-06 08:15:26 UTC) #2
ngeoffray
On 2012/09/06 08:15:26, ahe wrote: > LGTM, please also revert CL 10911107. Thanks Peter. So ...
8 years, 3 months ago (2012-09-06 08:19:04 UTC) #3
ngeoffray
PTAL
8 years, 3 months ago (2012-09-06 09:03:00 UTC) #4
ngeoffray
On 2012/09/06 09:03:00, ngeoffray wrote: > PTAL I'll submit thisTBR to get time to monitor ...
8 years, 3 months ago (2012-09-06 10:47:38 UTC) #5
ahe
8 years, 3 months ago (2012-09-06 12:10:41 UTC) #6
LGTM!

https://chromiumcodereview.appspot.com/10912109/diff/9001/samples/tests/sampl...
File samples/tests/samples/samples.status (right):

https://chromiumcodereview.appspot.com/10912109/diff/9001/samples/tests/sampl...
samples/tests/samples/samples.status:87: *: Skip
Please add a TODO comment on the line with the word "skip".

Powered by Google App Engine
This is Rietveld 408576698