Issue 10912094: Reapply "Remove classes Computation and BindInstr."

Issue 10912094: Reapply "Remove classes Computation and BindInstr." (Closed)

Created:
8 years, 3 months ago by Kevin Millikin (Google)

Modified:
8 years, 3 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Reapply "Remove classes Computation and BindInstr." Reapply svn revision 11868 with a bugfix. Original code review at http://codereview.chromium.org/10908091/ R=fschneider@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=11890

Patch Set 1 #

Total comments: 1

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1738 lines, -1845 lines)			Patch
M	runtime/vm/flow_graph.h	View	2 chunks	+2 lines, -5 lines	0 comments	Download
M	runtime/vm/flow_graph.cc	View	8 chunks	+21 lines, -25 lines	0 comments	Download
M	runtime/vm/flow_graph_allocator.cc	View	3 chunks	+5 lines, -7 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.h	View	7 chunks	+24 lines, -24 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	67 chunks	+241 lines, -240 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.h	View	2 chunks	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_inliner.cc	View	3 chunks	+9 lines, -12 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.h	View	3 chunks	+26 lines, -35 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	33 chunks	+266 lines, -284 lines	1 comment	Download
M	runtime/vm/il_printer.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/il_printer.cc	View	28 chunks	+43 lines, -71 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	102 chunks	+629 lines, -755 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	41 chunks	+228 lines, -153 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	75 chunks	+106 lines, -110 lines	0 comments	Download
M	runtime/vm/intermediate_language_test.cc	View	2 chunks	+8 lines, -9 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	75 chunks	+107 lines, -111 lines	0 comments	Download
M	runtime/vm/locations.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Google)

http://codereview.chromium.org/10912094/diff/1/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (right): http://codereview.chromium.org/10912094/diff/1/runtime/vm/flow_graph_optimizer.cc#newcode887 runtime/vm/flow_graph_optimizer.cc:887: !defn->IsPushArgument() && This line is added.

8 years, 3 months ago (2012-09-05 12:50:09 UTC) #2

lgtm

Expand Messages | Collapse Messages