Issue 10912007: Remove buildin library reference from dart-analyzer test.

Issue 10912007: Remove buildin library reference from dart-analyzer test. (Closed)

Created:
8 years, 3 months ago by Anders Johnsen

Modified:
8 years, 3 months ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove buildin library reference from dart-analyzer test. BUG= Committed: https://code.google.com/p/dart/source/detail?r=11610

Patch Set 2 : Also remove comment #

Patch Set 3 : Also remove the builtin reference from lib/_internal. #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -18 lines)			Patch
	M	compiler/javatests/com/google/dart/compiler/SystemLibrariesReaderTest.java	View	1	1 chunk	+0 lines, -12 lines	0 comments	Download
	M	lib/_internal/libraries.dart	View	1 2	1 chunk	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

lgtm https://chromiumcodereview.appspot.com/10912007/diff/1/compiler/javatests/com/google/dart/compiler/SystemLibrariesReaderTest.java File compiler/javatests/com/google/dart/compiler/SystemLibrariesReaderTest.java (right): https://chromiumcodereview.appspot.com/10912007/diff/1/compiler/javatests/com/google/dart/compiler/SystemLibrariesReaderTest.java#newcode52 compiler/javatests/com/google/dart/compiler/SystemLibrariesReaderTest.java:52: // "builtin": const LibraryInfo( Please remove the comment ...

8 years, 3 months ago (2012-08-30 12:01:29 UTC) #2

Mads Ager (google)

On 2012/08/30 12:01:29, Mads Ager wrote: > lgtm > > https://chromiumcodereview.appspot.com/10912007/diff/1/compiler/javatests/com/google/dart/compiler/SystemLibrariesReaderTest.java > File compiler/javatests/com/google/dart/compiler/SystemLibrariesReaderTest.java > ...

8 years, 3 months ago (2012-08-30 12:03:35 UTC) #3

Anders Johnsen

PTAL https://chromiumcodereview.appspot.com/10912007/diff/1/compiler/javatests/com/google/dart/compiler/SystemLibrariesReaderTest.java File compiler/javatests/com/google/dart/compiler/SystemLibrariesReaderTest.java (right): https://chromiumcodereview.appspot.com/10912007/diff/1/compiler/javatests/com/google/dart/compiler/SystemLibrariesReaderTest.java#newcode52 compiler/javatests/com/google/dart/compiler/SystemLibrariesReaderTest.java:52: // "builtin": const LibraryInfo( On 2012/08/30 12:01:29, Mads ...

8 years, 3 months ago (2012-08-30 12:04:01 UTC) #4

LGTM!

Expand Messages | Collapse Messages