Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Issue 10911221: show category information for sdk libs (Closed)

Created:
8 years, 3 months ago by keertip
Modified:
8 years, 3 months ago
Reviewers:
devoncarew, danrubel
CC:
reviews_dartlang.org
Visibility:
Public.

Description

show category information for sdk libs Committed: https://code.google.com/p/dart/source/detail?r=12267

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Messages

Total messages: 4 (0 generated)
keertip
- add category info to sdk lib nodes. Shown only if library is not a ...
8 years, 3 months ago (2012-09-11 18:17:28 UTC) #1
devoncarew
lgtm https://chromiumcodereview.appspot.com/10911221/diff/1/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/filesview/DartDirectoryNode.java File editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/filesview/DartDirectoryNode.java (right): https://chromiumcodereview.appspot.com/10911221/diff/1/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/filesview/DartDirectoryNode.java#newcode81 editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/filesview/DartDirectoryNode.java:81: if (!category.equals("shared")) { I don't love this; maybe ...
8 years, 3 months ago (2012-09-11 21:05:08 UTC) #2
keertip
https://chromiumcodereview.appspot.com/10911221/diff/1/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/filesview/DartDirectoryNode.java File editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/filesview/DartDirectoryNode.java (right): https://chromiumcodereview.appspot.com/10911221/diff/1/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/filesview/DartDirectoryNode.java#newcode81 editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/filesview/DartDirectoryNode.java:81: if (!category.equals("shared")) { On 2012/09/11 21:05:08, devoncarew wrote: > ...
8 years, 3 months ago (2012-09-11 21:14:45 UTC) #3
danrubel
8 years, 3 months ago (2012-09-12 03:07:42 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698