Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 10911206: Remove support for operator negate and replace occurrences with unary (Closed)

Created:
8 years, 3 months ago by kasperl
Modified:
8 years, 3 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove support for operator negate and replace occurrences with unary operator -. In the VM, I have disabled the operator negate support in the parser but I have not removed the keyword because the token is used in quite a few other places. R=ahe@google.com,iposva@google.com,hausner@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=12233

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -44 lines) Patch
M editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/model/testsource/NamingTest.dart View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/model/testsource/OperatorTest.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/lib/interceptors.dart View 1 chunk +0 lines, -7 lines 0 comments Download
M lib/compiler/implementation/scanner/parser.dart View 1 chunk +1 line, -3 lines 0 comments Download
M lib/core/double.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/core/int.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/core/num.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/fixnum/int32.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/fixnum/int64.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/fixnum/intx.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/double.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/integers.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/parser.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M runtime/vm/token.h View 2 chunks +1 line, -4 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 chunk +9 lines, -0 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 chunk +6 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/mirrors_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/parser_test.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M tests/language/condition_bailout_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/naming_test.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M tests/language/operator3_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/operator_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
kasperl
8 years, 3 months ago (2012-09-11 10:34:38 UTC) #1
kasperl
Adding Brian as reviewer for the compiler/ parts.
8 years, 3 months ago (2012-09-11 10:48:10 UTC) #2
kasperl
Woops. Meant: Adding Brian as reviewer for the editor parts.
8 years, 3 months ago (2012-09-11 10:48:42 UTC) #3
ahe
LGTM
8 years, 3 months ago (2012-09-11 13:13:30 UTC) #4
hausner
8 years, 3 months ago (2012-09-11 16:59:20 UTC) #5
VM changes LGTM. I can remove the remaining occurrences of kNEGATE.

Powered by Google App Engine
This is Rietveld 408576698