Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 10911205: Print error output from DumpRenderTree updater in test.dart. (Closed)

Created:
8 years, 3 months ago by Bill Hesse
Modified:
8 years, 3 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Print error output from DumpRenderTree updater in test.dart. BUG=dart:4157 Committed: https://code.google.com/p/dart/source/detail?r=12195

Patch Set 1 #

Patch Set 2 : Remove stray debugging print statements. #

Patch Set 3 : Abort if update script fails. #

Patch Set 4 : Do not commit injected error. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -15 lines) Patch
M tools/testing/dart/drt_updater.dart View 1 2 3 2 chunks +20 lines, -12 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bill Hesse
Do you think the test script should stop, or continue running, in the case where ...
8 years, 3 months ago (2012-09-11 09:45:28 UTC) #1
Bill Hesse
Now the test script quits if the updater fails.
8 years, 3 months ago (2012-09-11 12:16:40 UTC) #2
ahe
8 years, 3 months ago (2012-09-11 12:50:41 UTC) #3
LGTM!

Powered by Google App Engine
This is Rietveld 408576698