Issue 10911201: Reapply changes to Expando patching.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10911201: Reapply changes to Expando patching. (Closed)

Created:
8 years, 3 months ago by Mads Ager (google)

Modified:
8 years, 3 months ago

Reviewers:
Anders Johnsen, Ivan Posva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Reapply changes to Expando patching. R=ajohnsen@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=12181

Patch Set 1 #

Patch Set 2 : Move WeakProperty from coreimpl to core in the internals of the VM as well. #

Patch Set 3 : Move code around a bit. #

Total comments: 1

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -59 lines)			Patch
M	lib/compiler/implementation/lib/core_patch.dart	View	1	1 chunk	+32 lines, -0 lines	0 comments	Download
M	lib/compiler/implementation/lib/coreimpl.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	lib/compiler/implementation/lib/coreimpl_patch.dart	View		1 chunk	+0 lines, -33 lines	0 comments	Download
M	lib/core/expando.dart	View		2 chunks	+9 lines, -4 lines	0 comments	Download
M	lib/coreimpl/coreimpl.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	lib/coreimpl/corelib_impl_sources.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download
D	lib/coreimpl/expando.dart	View		1 chunk	+0 lines, -11 lines	0 comments	Download
M	runtime/lib/expando_patch.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/lib/lib_impl_sources.gypi	View		1 chunk	+0 lines, -1 line	1 comment	Download
M	runtime/lib/lib_sources.gypi	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 2	2 chunks	+5 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

5 char fix and we can reapply. See patch set 2. The only real change ...

8 years, 3 months ago (2012-09-11 10:48:56 UTC) #1

Ivan Posva

8 years, 3 months ago (2012-09-12 20:45:55 UTC) #3

Thanks!
-Ivan

https://chromiumcodereview.appspot.com/10911201/diff/11001/runtime/lib/lib_im...
File runtime/lib/lib_impl_sources.gypi (right):

https://chromiumcodereview.appspot.com/10911201/diff/11001/runtime/lib/lib_im...
runtime/lib/lib_impl_sources.gypi:33: 'weak_property.dart',
In the future please avoid supplying duplicates in dart:core and dart:coreimpl.

Expand Messages | Collapse Messages