Issue 10911154: Adding parens back in to generated getters/setters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10911154: Adding parens back in to generated getters/setters. (Closed)

Created:
8 years, 3 months ago by blois

Modified:
8 years, 3 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org, kasperl

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Adding parens back in to generated getters/setters. This is only until we get the generators to correctly omit them. I've opened bug #4992 to track fixing up the generators. This CL just represents the results of re-generating the HTML lib, nothing else. BUG= Committed: https://code.google.com/p/dart/source/detail?r=12051

Patch Set 1 #

Patch Set 2 : Sync to tip of tree. #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2992 lines, -2992 lines)			Patch
	M	lib/html/dart2js/html_dart2js.dart	View		504 chunks	+1500 lines, -1500 lines	0 comments	Download
	M	lib/html/dartium/html_dartium.dart	View		503 chunks	+1492 lines, -1492 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

vsm

8 years, 3 months ago (2012-09-07 18:09:35 UTC) #2

lgtm

Kasper: we'll fix this upstream in the scripts.  Please let us know if it's
blocking you guys.

Expand Messages | Collapse Messages