Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 10911112: dartc can't compile dart:io, fix status to avoid using it (Closed)

Created:
8 years, 3 months ago by Alan Knight
Modified:
8 years, 3 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

dartc can't compile dart:io, fix status to avoid using it Committed: https://code.google.com/p/dart/source/detail?r=11904

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M pkg/pkg.status View 1 chunk +6 lines, -1 line 1 comment Download

Messages

Total messages: 6 (0 generated)
Alan Knight
This changes the status file to avoid running the failing test on dartc, and also ...
8 years, 3 months ago (2012-09-05 21:12:52 UTC) #1
scheglov
LGTM
8 years, 3 months ago (2012-09-05 21:14:15 UTC) #2
Emily Fortuna
lgtm with comment https://chromiumcodereview.appspot.com/10911112/diff/1/pkg/pkg.status File pkg/pkg.status (right): https://chromiumcodereview.appspot.com/10911112/diff/1/pkg/pkg.status#newcode24 pkg/pkg.status:24: [ $compiler == dartc] have you ...
8 years, 3 months ago (2012-09-05 21:15:06 UTC) #3
Alan Knight
On 2012/09/05 21:15:06, Emily Fortuna wrote: > lgtm with comment > > https://chromiumcodereview.appspot.com/10911112/diff/1/pkg/pkg.status > File ...
8 years, 3 months ago (2012-09-05 21:23:36 UTC) #4
Emily Fortuna
On 2012/09/05 21:23:36, Alan Knight wrote: > On 2012/09/05 21:15:06, Emily Fortuna wrote: > > ...
8 years, 3 months ago (2012-09-05 21:27:24 UTC) #5
danrubel
8 years, 3 months ago (2012-09-05 22:06:00 UTC) #6
On 2012/09/05 21:27:24, Emily Fortuna wrote:
> On 2012/09/05 21:23:36, Alan Knight wrote:
> > On 2012/09/05 21:15:06, Emily Fortuna wrote:
> > > lgtm with comment
> > > 
> > > https://chromiumcodereview.appspot.com/10911112/diff/1/pkg/pkg.status
> > > File pkg/pkg.status (right):
> > > 
> > >
> >
>
https://chromiumcodereview.appspot.com/10911112/diff/1/pkg/pkg.status#newcode24
> > > pkg/pkg.status:24: [ $compiler == dartc]
> > > have you been able to get in touch with whoever worked on these? Can we
just
> > > delete that html file?
> > 
> > The hyphens rather than underscores code was committed by sgjesse in April.
> > There appear to be multiple other errors as well. It seems like it might not
> be
> > being used other than by dartc when dart:io is imported, but I don't know
how
> to
> > tell.
> 
> Try a grep through our tree. If not, let's try to delete it and see if
anything
> breaks. :-) Better to clear out stuff than possibly leaving it because it will
> only become more confusing later on as the file gets more out of date.

Its pulled in by create_sdk and becomes part of dart:io
+1 to cleanup or remove

Powered by Google App Engine
This is Rietveld 408576698