Issue 10911091: Add empty mapping entries for the ranges of generated JavaScript that don't map to any Dart source …

Issue 10911091: Add empty mapping entries for the ranges of generated JavaScript that don't map to any Dart source … (Closed)

Created:
8 years, 3 months ago by podivilov

Modified:
8 years, 3 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add empty mapping entries for the ranges of generated JavaScript that don't map to any Dart source code. For such ranges we want to show generated JavaScript rather than arbitrary location in Dart sources. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=11934

Patch Set 1 #

Total comments: 12

Patch Set 2 : . #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -24 lines)			Patch
M	lib/compiler/implementation/code_buffer.dart	View	1	3 chunks	+11 lines, -0 lines	0 comments	Download
M	lib/compiler/implementation/js/printer.dart	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	lib/compiler/implementation/js_backend/emitter.dart	View	1	7 chunks	+9 lines, -9 lines	0 comments	Download
M	lib/compiler/implementation/source_map_builder.dart	View	1	1 chunk	+11 lines, -8 lines	0 comments	Download
M	tests/compiler/dart2js/source_mapping_test.dart	View		2 chunks	+9 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. https://chromiumcodereview.appspot.com/10911091/diff/1/lib/compiler/implementation/code_buffer.dart File lib/compiler/implementation/code_buffer.dart (right): https://chromiumcodereview.appspot.com/10911091/diff/1/lib/compiler/implementation/code_buffer.dart#newcode29 lib/compiler/implementation/code_buffer.dart:29: if (mappedRangeCounter == 0) { one line. https://chromiumcodereview.appspot.com/10911091/diff/1/lib/compiler/implementation/code_buffer.dart#newcode75 ...

8 years, 3 months ago (2012-09-05 14:22:18 UTC) #2

podivilov

8 years, 3 months ago (2012-09-06 10:52:25 UTC) #3

https://chromiumcodereview.appspot.com/10911091/diff/1/lib/compiler/implement...
File lib/compiler/implementation/code_buffer.dart (right):

https://chromiumcodereview.appspot.com/10911091/diff/1/lib/compiler/implement...
lib/compiler/implementation/code_buffer.dart:29: if (mappedRangeCounter == 0) {
On 2012/09/05 14:22:18, floitsch wrote:
> one line.

Done.

https://chromiumcodereview.appspot.com/10911091/diff/1/lib/compiler/implement...
lib/compiler/implementation/code_buffer.dart:75: mappedRangeCounter += 1;
On 2012/09/05 14:22:18, floitsch wrote:
> ++

Done.

https://chromiumcodereview.appspot.com/10911091/diff/1/lib/compiler/implement...
lib/compiler/implementation/code_buffer.dart:80: mappedRangeCounter -= 1;
On 2012/09/05 14:22:18, floitsch wrote:
> --

Done.

https://chromiumcodereview.appspot.com/10911091/diff/1/lib/compiler/implement...
File lib/compiler/implementation/js/printer.dart (right):

https://chromiumcodereview.appspot.com/10911091/diff/1/lib/compiler/implement...
lib/compiler/implementation/js/printer.dart:62: if (node.sourcePosition != null)
{
On 2012/09/05 14:22:18, floitsch wrote:
> one line.

Done.

https://chromiumcodereview.appspot.com/10911091/diff/1/lib/compiler/implement...
lib/compiler/implementation/js/printer.dart:68: if (node.sourcePosition != null)
{
On 2012/09/05 14:22:18, floitsch wrote:
> one line.

Done.

https://chromiumcodereview.appspot.com/10911091/diff/1/lib/compiler/implement...
File lib/compiler/implementation/source_map_builder.dart (right):

https://chromiumcodereview.appspot.com/10911091/diff/1/lib/compiler/implement...
lib/compiler/implementation/source_map_builder.dart:79: // TODO(podivilov): make
sure enties are always associated with the right
On 2012/09/05 14:22:18, floitsch wrote:
> entries

Done.

Expand Messages | Collapse Messages