Moved assertion test from VM tests to language. Since it fails with

Moved assertion test from VM tests to language.  Since it fails with
dart2js, filed issue 4929 and disabled the test.
Committed: https://code.google.com/p/dart/source/detail?r=11851

[Tom Ball, 2012-09-04 23:48:36]

In fixing a problem with the VM parser skipping assert statements with generic
types, I found a different failure in dart2js.  Issue 4929 was filed for it, and
I moved my test to tests/languages and disabled it in language_dart2js.status.

[siva, 2012-09-04 23:58:09]

lgtm

[kasperl, 2012-09-05 05:41:28]

LGTM (except for the .dart suffix in the status file).

http://codereview.chromium.org/10911083/diff/1/tests/language/assert_with_typ...
File tests/language/assert_with_type_test_or_cast_test.dart (right):

http://codereview.chromium.org/10911083/diff/1/tests/language/assert_with_typ...
tests/language/assert_with_type_test_or_cast_test.dart:11: // VMOptions=
It is somewhat painful to see these VMOptions comments appear in language tests
(I'm sure we still have a bunch of them in other files). Wouldn't our test
coverage for this file in checked mode be enough?

[Tom Ball, 2012-09-05 16:06:48]

On 2012/09/05 05:41:28, kasperl wrote:
> LGTM (except for the .dart suffix in the status file).

Shiva fixed that in a following change (thanks!).

>
http://codereview.chromium.org/10911083/diff/1/tests/language/assert_with_typ...
> File tests/language/assert_with_type_test_or_cast_test.dart (right):
> 
>
http://codereview.chromium.org/10911083/diff/1/tests/language/assert_with_typ...
> tests/language/assert_with_type_test_or_cast_test.dart:11: // VMOptions=
> It is somewhat painful to see these VMOptions comments appear in language
tests
> (I'm sure we still have a bunch of them in other files). Wouldn't our test
> coverage for this file in checked mode be enough?

Are languages tests run both in checked and unchecked modes?  The problem this
test checks in the VM only shows up in unchecked mode, as generic types in
assertion statements weren't skipped completely.  In dart2js, though, the test
found an error that shows up in checked mode.  If tests are run in both modes,
I'll happily remove the options.