Issue 10911066: Make an empty identifier a scanning error.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10911066: Make an empty identifier a scanning error. (Closed)

Created:
8 years, 3 months ago by Lasse Reichstein Nielsen

Modified:
8 years, 3 months ago

Reviewers:
ahe, kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make an empty identifier a scanning error. This only happens in string interpolations, since it is the only place where an identifier is scanned without first seeing at least one character of the identifier. BUG=4899 Committed: https://code.google.com/p/dart/source/detail?r=11927

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add test. Fix typo. #

Patch Set 3 : Added more tests. #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -0 lines)			Patch
	M	lib/compiler/implementation/scanner/scanner.dart	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
	A	tests/language/string_interpolation9_test.dart	View	1 2	1 chunk	+35 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

kasperl

https://chromiumcodereview.appspot.com/10911066/diff/1/lib/compiler/implementation/scanner/scanner.dart File lib/compiler/implementation/scanner/scanner.dart (right): https://chromiumcodereview.appspot.com/10911066/diff/1/lib/compiler/implementation/scanner/scanner.dart#newcode658 lib/compiler/implementation/scanner/scanner.dart:658: throw new MalformedInputException("expected identifier not fonud", fonud -> found

8 years, 3 months ago (2012-09-04 14:34:37 UTC) #2

Lasse Reichstein Nielsen

8 years, 3 months ago (2012-09-06 08:39:23 UTC) #6

On 2012/09/05 15:37:55, ahe wrote:
> LGTM, I assume we already test "$$" somewhere.

Not sure we do. Let's add it here too, just for good measure.

Expand Messages | Collapse Messages