Fixed parsing of parameterized type test assert statement in production mode.

Fixed parsing of parameterized type test assert statement in production mode.

BUG=3741
TEST=Verified with bug's test, plus all VM tests.
Committed: https://code.google.com/p/dart/source/detail?r=11843

[hausner, 2012-08-31 23:31:35]

LGTM with comment. If you want me to take another look after you address the
comment, feel free to ask.

http://codereview.chromium.org/10911042/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

http://codereview.chromium.org/10911042/diff/1/runtime/vm/parser.cc#newcode9346
runtime/vm/parser.cc:9346: if (CurrentToken() == Token::kIS) {
I think there is another bug here. After the keyword 'as' we also need to skip a
type, not a unary expression. E.g:

assert((e as List<int>).length == 10);

If we don't have any tests for this, it would be good to add one and run it with
assertions enabled and disabled, so we both parse the expression (if assertions
are enabled) and skip the expression (if assertions are disabled).

[Tom Ball, 2012-09-04 21:05:03]

Added support for type casts, and a test that checks both types of expressions.

[hausner, 2012-09-04 21:16:05]

This looks good now. As a bonus, you could run the test twice, once with
assertions enabled, once disabled. In the first case, the expressions get parsed
and at runtime evaluated, in the second case the expressions get skipped.

To achieve this, you can add these two comment lines at the beginning of the
dart test:

// VMOptions=
// VMOptions=--enable_asserts

LGTM.