Mark flaky test as such.

Mark flaky test as such.

Committed: https://code.google.com/p/dart/source/detail?r=12341

[ahe, 2012-09-13 17:40:51]

TBR'ed

[Bob Nystrom, 2012-09-13 17:42:28]

LGTM

[Emily Fortuna, 2012-09-13 17:43:40]

please don't commit. Please see Issue
http://code.google.com/p/dart/issues/detail?id=5152 first.

[ahe, 2012-09-13 17:47:47]

On 2012/09/13 17:43:40, Emily Fortuna wrote:
> please don't commit. Please see Issue
> http://code.google.com/p/dart/issues/detail?id=5152 first.

I did already commit. I'll investigate further.

[ricow1, 2012-09-13 17:52:42]

On 2012/09/13 17:47:47, ahe wrote:
> On 2012/09/13 17:43:40, Emily Fortuna wrote:
> > please don't commit. Please see Issue
> > http://code.google.com/p/dart/issues/detail?id=5152 first.
> 
> I did already commit. I'll investigate further.

Emily: Just currious here: Any guesses as to why this particular test is flaking
so much? If this specific test is really this flaky I assume that we would often
get a false negative even when rerunning it? Since we don't have a flakiness
dashboard like chromium we have to catch these by hand I guess (I am not
implying that I would like a flakiness dashboard :-) )

[ahe, 2012-09-13 18:33:18]

On 2012/09/13 17:52:42, ricow1 wrote:
> On 2012/09/13 17:47:47, ahe wrote:
> > On 2012/09/13 17:43:40, Emily Fortuna wrote:
> > > please don't commit. Please see Issue
> > > http://code.google.com/p/dart/issues/detail?id=5152 first.
> > 
> > I did already commit. I'll investigate further.
> 
> Emily: Just currious here: Any guesses as to why this particular test is
flaking
> so much? If this specific test is really this flaky I assume that we would
often
> get a false negative even when rerunning it? Since we don't have a flakiness
> dashboard like chromium we have to catch these by hand I guess (I am not
> implying that I would like a flakiness dashboard :-) )

As far as I can tell, html/window_open is really flaky. The problem is that it
tries to inject some JS code:

  evaluateJavaScript('(testRunner ||
layoutTestController).setCanOpenWindows()');

This will lead to a call to setCanOpenWindows() on undefined in selenium where
testRunner and layoutTestController aren't defined.

I'm actually seeing this being a problem when I run this test in chrome and hit
reload: test_controller.js does write FAIL, but the unittest framework overrides
the output with document.body.innerHTML.