Issue 4988. Fixe for 'assert' statement vs function resolving

Issue 4988. Fixe for 'assert' statement vs function resolving
http://code.google.com/p/dart/issues/detail?id=4988


R=brianwilkerson@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=12071

[Brian Wilkerson, 2012-09-07 21:09:59]

Once the concern about possible name collisions is resolved, LGTM.

https://chromiumcodereview.appspot.com/10910142/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/DartCompiler.java (right):

https://chromiumcodereview.appspot.com/10910142/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/DartCompiler.java:864: srcCode += "\nvoid
assert__forStatement(x) {}";
I think we want to choose a name that can't easily be duplicated in user code.
How about something that includes the millisecond clock value. (This would, of
course require caching the name in a static final field somewhere, which would
be good anyway.)

[scheglov, 2012-09-07 22:05:11]

https://chromiumcodereview.appspot.com/10910142/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/DartCompiler.java (right):

https://chromiumcodereview.appspot.com/10910142/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/DartCompiler.java:864: srcCode += "\nvoid
assert__forStatement(x) {}";
On 2012/09/07 21:09:59, Brian Wilkerson wrote:
> I think we want to choose a name that can't easily be duplicated in user code.
> How about something that includes the millisecond clock value. (This would, of
> course require caching the name in a static final field somewhere, which would
> be good anyway.)

Done.