Issue 10910098: Re-apply with a few fixes http://codereview.chromium.org/10913081/: Fix resolution of type paramete…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10910098: Re-apply with a few fixes http://codereview.chromium.org/10913081/: Fix resolution of type paramete… (Closed)

Created:
8 years, 3 months ago by ngeoffray

Modified:
8 years, 2 months ago

Reviewers:
ahe, floitsch

CC:
reviews_dartlang.org, Johnni Winther, karlklose

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Re-apply with a few fixes http://codereview.chromium.org/10913081/: Fix resolution of type parameters in static context, and the use of type parameters in closures. Committed: https://code.google.com/p/dart/source/detail?r=11966

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 1

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+169 lines, -56 lines)			Patch
M	lib/compiler/implementation/closure.dart	View	1 2	7 chunks	+47 lines, -34 lines	0 comments	Download
M	lib/compiler/implementation/elements/elements.dart	View	1 2	3 chunks	+23 lines, -3 lines	1 comment	Download
M	lib/compiler/implementation/resolver.dart	View	1 2	7 chunks	+30 lines, -14 lines	0 comments	Download
M	lib/compiler/implementation/ssa/builder.dart	View	1 2	1 chunk	+8 lines, -3 lines	0 comments	Download
M	tests/co19/co19-dart2js.status	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/language/language.status	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download
M	tests/language/language_dart2js.status	View	1 2	1 chunk	+5 lines, -1 line	0 comments	Download
A	tests/language/type_parameter_test.dart	View	1	1 chunk	+50 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

Patch set 1 contains the original CL, patch set 2 contains the fixes.

8 years, 3 months ago (2012-09-05 21:27:55 UTC) #1

ahe

8 years, 2 months ago (2012-10-01 16:17:28 UTC) #4

I think we need to take a closer look at this change.

https://chromiumcodereview.appspot.com/10910098/diff/7002/lib/compiler/implem...
File lib/compiler/implementation/elements/elements.dart (right):

https://chromiumcodereview.appspot.com/10910098/diff/7002/lib/compiler/implem...
lib/compiler/implementation/elements/elements.dart:765: Scope buildScope() {
I think this method is problematic for several reasons:

1. A variable list does not introduce a scope.

2. The method relies on the enclosing class scope not being cached and mutates
it.

3. The scope is the same no matter if you're in static context, and the
specification now reflects this.

Expand Messages | Collapse Messages