Issue 10910092: Improvements for checked mode: check when intializing fields, and when assigning to fields.

Issue 10910092: Improvements for checked mode: check when intializing fields, and when assigning to fields. (Closed)

Created:
8 years, 3 months ago by ngeoffray

Modified:
8 years, 3 months ago

Reviewers:
floitsch, kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Improvements for checked mode: check when intializing fields, and when assigning to fields. Committed: https://code.google.com/p/dart/source/detail?r=11962

Patch Set 3 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+173 lines, -45 lines)			Patch
M	lib/compiler/implementation/ssa/builder.dart	View	1 2	3 chunks	+9 lines, -30 lines	0 comments	Download
M	lib/compiler/implementation/ssa/nodes.dart	View	1 2	1 chunk	+23 lines, -0 lines	0 comments	Download
M	lib/compiler/implementation/ssa/optimize.dart	View	1 2	1 chunk	+10 lines, -1 line	0 comments	Download
M	pkg/pkg.status	View	1 2	1 chunk	+28 lines, -2 lines	0 comments	Download
M	tests/co19/co19-dart2js.status	View	1 2	3 chunks	+72 lines, -6 lines	0 comments	Download
M	tests/isolate/isolate.status	View	1 2	1 chunk	+18 lines, -0 lines	0 comments	Download
M	tests/language/field_override_test.dart	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/language/language.status	View	1 2	2 chunks	+3 lines, -1 line	0 comments	Download
M	tests/language/language_dart2js.status	View	1 2	1 chunk	+0 lines, -3 lines	0 comments	Download
M	tests/language/super_closure_test.dart	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/standalone/standalone.status	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/utils/utils.status	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	utils/tests/pub/pub.status	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. Thank you for enabling a bunch of tests in checked mode! http://codereview.chromium.org/10910092/diff/2001/lib/compiler/implementation/ssa/nodes.dart File lib/compiler/implementation/ssa/nodes.dart ...

8 years, 3 months ago (2012-09-06 10:20:39 UTC) #2

ngeoffray

8 years, 3 months ago (2012-09-06 16:12:03 UTC) #4

https://chromiumcodereview.appspot.com/10910092/diff/2001/lib/compiler/implem...
File lib/compiler/implementation/ssa/nodes.dart (right):

https://chromiumcodereview.appspot.com/10910092/diff/2001/lib/compiler/implem...
lib/compiler/implementation/ssa/nodes.dart:1106: HInstruction instruction = new
HTypeConversion(convertedType, this, kind);
On 2012/09/06 10:20:39, kasperl wrote:
> Maybe just return it here with creating a new local?

Done.

Expand Messages | Collapse Messages