Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 10910079: Catch illegally declared constructors (Closed)

Created:
8 years, 3 months ago by hausner
Modified:
8 years, 3 months ago
Reviewers:
regis
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Catch illegally declared constructors Constructors cannot be abstract or static. Committed: https://code.google.com/p/dart/source/detail?r=11842

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -2 lines) Patch
M runtime/vm/parser.cc View 1 3 chunks +8 lines, -2 lines 0 comments Download
A tests/language/bad_constructor_test.dart View 1 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
hausner
8 years, 3 months ago (2012-09-04 20:14:59 UTC) #1
regis
LGTM No tests?
8 years, 3 months ago (2012-09-04 20:47:18 UTC) #2
hausner
8 years, 3 months ago (2012-09-04 21:29:54 UTC) #3
Thanks. Added a test.

Powered by Google App Engine
This is Rietveld 408576698