Issue 10909168: Introduce nested deoptimization environments.

Issue 10909168: Introduce nested deoptimization environments. (Closed)

Created:
8 years, 3 months ago by Kevin Millikin (Google)

Modified:
8 years, 3 months ago

Reviewers:
Florian Schneider, zerny-google

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Introduce nested deoptimization environments. Add an optional outer deoptimization environment to support inlining. Introduce a pair of environment iterators. Original codereview: https://chromiumcodereview.appspot.com/10928048/ R=fschneider@google.com,zerny@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=12190

Patch Set 1 #

Total comments: 4

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+206 lines, -80 lines)			Patch
M	runtime/vm/flow_graph.cc	View	9 chunks	+22 lines, -19 lines	0 comments	Download
M	runtime/vm/flow_graph_allocator.cc	View	5 chunks	+18 lines, -18 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler.cc	View	2 chunks	+11 lines, -8 lines	0 comments	Download
M	runtime/vm/flow_graph_inliner.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	runtime/vm/il_printer.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	2 chunks	+119 lines, -15 lines	2 comments	Download
M	runtime/vm/intermediate_language.cc	View	1 chunk	+28 lines, -13 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

lgtm https://chromiumcodereview.appspot.com/10909168/diff/1/runtime/vm/intermediate_language.cc File runtime/vm/intermediate_language.cc (right): https://chromiumcodereview.appspot.com/10909168/diff/1/runtime/vm/intermediate_language.cc#newcode1648 runtime/vm/intermediate_language.cc:1648: for (Environment::DeepIterator it(copy); !it.Done(); it.Advance()) { Maybe rename ...

8 years, 3 months ago (2012-09-11 12:07:38 UTC) #2

Kevin Millikin (Google)

8 years, 3 months ago (2012-09-11 12:38:15 UTC) #3

https://chromiumcodereview.appspot.com/10909168/diff/1/runtime/vm/intermediat...
File runtime/vm/intermediate_language.cc (right):

https://chromiumcodereview.appspot.com/10909168/diff/1/runtime/vm/intermediat...
runtime/vm/intermediate_language.cc:1648: for (Environment::DeepIterator
it(copy); !it.Done(); it.Advance()) {
On 2012/09/11 12:07:38, Florian Schneider wrote:
> Maybe rename Copy and CopyTo into DeepCopy and DeepCopyTo to show the intended
> behaviour.

Done.

https://chromiumcodereview.appspot.com/10909168/diff/1/runtime/vm/intermediat...
File runtime/vm/intermediate_language.h (right):

https://chromiumcodereview.appspot.com/10909168/diff/1/runtime/vm/intermediat...
runtime/vm/intermediate_language.h:3237: SkipNull();
On 2012/09/11 12:07:38, Florian Schneider wrote:
> Maybe we can assert that all definitions in the environment are non-NULL?

Done.

Expand Messages | Collapse Messages