Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10909166: Rename NoSuchMethodException to NoSuchMethodError. (Closed)

Created:
8 years, 3 months ago by Lasse Reichstein Nielsen
Modified:
8 years, 3 months ago
Reviewers:
Johnni Winther, ahe, srdjan
CC:
reviews_dartlang.org, ahe
Visibility:
Public.

Description

Rename NoSuchMethodException to NoSuchMethodError. Moved NoSuchMethodError to errors.dart. No changes in co19 tests, but test status updated. Committed: https://code.google.com/p/dart/source/detail?r=12172

Patch Set 1 #

Total comments: 8

Patch Set 2 : Addressed review comments #

Patch Set 3 : Address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+208 lines, -176 lines) Patch
M lib/compiler/implementation/compiler.dart View 1 1 chunk +0 lines, -2 lines 0 comments Download
M lib/compiler/implementation/lib/core_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/lib/js_helper.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M lib/compiler/implementation/lib/native_helper.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/core/errors.dart View 1 1 chunk +58 lines, -0 lines 0 comments Download
M lib/core/exceptions.dart View 1 chunk +0 lines, -46 lines 0 comments Download
M lib/html/dartium/html_dartium.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/html/templates/html/impl/impl_Element.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M pkg/unittest/core_matchers.dart View 1 chunk +8 lines, -8 lines 0 comments Download
M pkg/unittest/test/matchers_test.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M runtime/vm/exceptions.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/stub_code_ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/stub_code_x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M tests/co19/co19-dart2js.status View 1 2 chunks +23 lines, -1 line 0 comments Download
M tests/compiler/dart2js_extra/interface_type_optimization_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_extra/regress/4492_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_extra/regress/4515_1_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_extra/regress/4515_2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_extra/regress/4740_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_extra/this_phi_elimination_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_foreign/native_class_inheritance1_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_foreign/native_class_inheritance3_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_foreign/native_method_rename1_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_foreign/native_method_rename2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_foreign/native_method_rename3_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_foreign/native_missing_method1_test.dart View 2 chunks +7 lines, -7 lines 0 comments Download
M tests/compiler/dart2js_foreign/native_missing_method2_test.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M tests/compiler/dart2js_foreign/native_no_such_method_exception2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_foreign/native_no_such_method_exception3_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_foreign/native_no_such_method_exception_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_foreign/native_window1_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_foreign/native_window2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_class_inheritance1_frog_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_class_inheritance3_frog_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_method_rename1_frog_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_method_rename2_frog_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_method_rename3_frog_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_missing_method1_frog_test.dart View 2 chunks +7 lines, -7 lines 0 comments Download
M tests/compiler/dart2js_native/native_missing_method2_frog_test.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M tests/compiler/dart2js_native/native_no_such_method_exception2_frog_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_no_such_method_exception3_frog_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_no_such_method_exception_frog_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_window1_frog_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_window2_frog_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib/core_runtime_types_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib/corelib.status View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/element_add_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/hidden_dom_1_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/hidden_dom_2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/html.status View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/html/inner_frame_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/html/unknownelement_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/window_nosuchmethod_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/language/abstract_getter_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/arithmetic2_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/language/bad_named_parameters2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/bad_named_parameters_test.dart View 5 chunks +5 lines, -5 lines 0 comments Download
M tests/language/call_nonexistent_constructor_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/language/call_nonexistent_static_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language/implied_interface_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language/is_nan_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/local_function3_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/language/local_function_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/naming_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/no_such_method_negative_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/language/private_main.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/language/savannah_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/language/string_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/utils/vim/syntax/dart.vim View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Lasse Reichstein Nielsen
8 years, 3 months ago (2012-09-11 08:33:43 UTC) #1
Johnni Winther
LGTM with comments https://chromiumcodereview.appspot.com/10909166/diff/1/lib/compiler/implementation/compiler.dart File lib/compiler/implementation/compiler.dart (right): https://chromiumcodereview.appspot.com/10909166/diff/1/lib/compiler/implementation/compiler.dart#newcode158 lib/compiler/implementation/compiler.dart:158: static const SourceString NO_SUCH_METHOD_EXCEPTION = Shouldn't ...
8 years, 3 months ago (2012-09-11 08:41:38 UTC) #2
ahe
LGTM! https://chromiumcodereview.appspot.com/10909166/diff/1/lib/html/dartium/html_dartium.dart File lib/html/dartium/html_dartium.dart (left): https://chromiumcodereview.appspot.com/10909166/diff/1/lib/html/dartium/html_dartium.dart#oldcode7247 lib/html/dartium/html_dartium.dart:7247: - throw new NoSuchMethodException(this, name, args); I think ...
8 years, 3 months ago (2012-09-11 08:43:56 UTC) #3
srdjan
lgtm
8 years, 3 months ago (2012-09-11 09:06:49 UTC) #4
srdjan
lgtm
8 years, 3 months ago (2012-09-11 09:06:51 UTC) #5
Lasse Reichstein Nielsen
8 years, 3 months ago (2012-09-11 11:35:41 UTC) #6 
https://chromiumcodereview.appspot.com/10909166/diff/1/lib/compiler/implement...
File lib/compiler/implementation/compiler.dart (right):

https://chromiumcodereview.appspot.com/10909166/diff/1/lib/compiler/implement...
lib/compiler/implementation/compiler.dart:158: static const SourceString
NO_SUCH_METHOD_EXCEPTION =
I'll remove it. It isn't used.

https://chromiumcodereview.appspot.com/10909166/diff/1/lib/core/errors.dart
File lib/core/errors.dart (right):

https://chromiumcodereview.appspot.com/10909166/diff/1/lib/core/errors.dart#n...
lib/core/errors.dart:35: const NoSuchMethodError(Object this._receiver,
Done.

https://chromiumcodereview.appspot.com/10909166/diff/1/lib/html/dartium/html_...
File lib/html/dartium/html_dartium.dart (left):

https://chromiumcodereview.appspot.com/10909166/diff/1/lib/html/dartium/html_...
lib/html/dartium/html_dartium.dart:7247: -      throw new
NoSuchMethodException(this, name, args);
I'll keep the change and tell them to update the generator.

Why, oh why, do we have generated files in the repository, but not the
generator. That's simply not acceptable to have "do-not-edit" files in the
repository.

https://chromiumcodereview.appspot.com/10909166/diff/1/tests/co19/co19-dart2j...
File tests/co19/co19-dart2js.status (right):

https://chromiumcodereview.appspot.com/10909166/diff/1/tests/co19/co19-dart2j...
tests/co19/co19-dart2js.status:68: Language/03_Overview/2_Privacy_A01_t18: Fail
On 2012/09/11 08:43:56, ahe wrote:
> Please use:
> 
> : Fail, OK # co19 issue 195

Done.

Powered by Google App Engine
This is Rietveld 408576698