Issue 10909098: Fix Token::kAS and its printing according to Regis' comment.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10909098: Fix Token::kAS and its printing according to Regis' comment. (Closed)

Created:
8 years, 3 months ago by srdjan

Modified:
8 years, 3 months ago

Reviewers:
regis

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix Token::kAS and its printing according to Regis' comment. Committed: https://code.google.com/p/dart/source/detail?r=11968

Patch Set 4 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -2 lines)			Patch
	M	runtime/vm/ast_printer.cc	View	1 2 3	1 chunk	+7 lines, -1 line	0 comments	Download
	M	runtime/vm/token.h	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM with indentation to fix. https://chromiumcodereview.appspot.com/10909098/diff/4001/runtime/vm/token.h File runtime/vm/token.h (right): https://chromiumcodereview.appspot.com/10909098/diff/4001/runtime/vm/token.h#newcode114 runtime/vm/token.h:114: TOK(kAS, "", 10, kNoAttribute) ...

8 years, 3 months ago (2012-09-06 16:11:02 UTC) #2

srdjan

8 years, 3 months ago (2012-09-06 17:03:45 UTC) #3

https://chromiumcodereview.appspot.com/10909098/diff/4001/runtime/vm/token.h
File runtime/vm/token.h (right):

https://chromiumcodereview.appspot.com/10909098/diff/4001/runtime/vm/token.h#...
runtime/vm/token.h:114: TOK(kAS, "", 10, kNoAttribute)                          
                  \
On 2012/09/06 16:11:02, regis wrote:
> \ -> col 80

Done.

Expand Messages | Collapse Messages

Issue 10909098: Fix Token::kAS and its printing according to Regis' comment. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Messages