Issue 10909081: Fix tests and update status files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10909081: Fix tests and update status files. (Closed)

Created:
8 years, 3 months ago by floitsch

Modified:
8 years, 3 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix tests and update status files. Committed: https://code.google.com/p/dart/source/detail?r=11871

Patch Set 1 #

Total comments: 2

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -120 lines)			Patch
M	tests/language/final_syntax_test.dart	View	1 chunk	+1 line, -1 line	2 comments	Download
M	tests/language/language.status	View	3 chunks	+9 lines, -5 lines	0 comments	Download
M	tests/language/language_dart2js.status	View	1 chunk	+1 line, -1 line	0 comments	Download
D	tests/language/lazy_final2_test.dart	View	1 chunk	+0 lines, -10 lines	0 comments	Download
D	tests/language/lazy_final3_test.dart	View	1 chunk	+0 lines, -56 lines	0 comments	Download
D	tests/language/lazy_final_test.dart	View	1 chunk	+0 lines, -48 lines	0 comments	Download
A +	tests/language/lazy_static2_test.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	tests/language/lazy_static3_test.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	tests/language/lazy_static_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. https://chromiumcodereview.appspot.com/10909081/diff/1/tests/language/final_syntax_test.dart File tests/language/final_syntax_test.dart (right): https://chromiumcodereview.appspot.com/10909081/diff/1/tests/language/final_syntax_test.dart#newcode41 tests/language/final_syntax_test.dart:41: final x, y; I guess these should really ...

8 years, 3 months ago (2012-09-05 11:55:19 UTC) #2

kasperl

8 years, 3 months ago (2012-09-05 11:55:57 UTC) #3

https://chromiumcodereview.appspot.com/10909081/diff/1/tests/language/final_s...
File tests/language/final_syntax_test.dart (right):

https://chromiumcodereview.appspot.com/10909081/diff/1/tests/language/final_s...
tests/language/final_syntax_test.dart:41: final x, y;
On 2012/09/05 11:55:19, kasperl wrote:
> I guess these should really be const too.

Strike that. Final should be okay.

Expand Messages | Collapse Messages