Issue 10908214: Revert "Whenever possible use length passed to the List constructor for bounds checks instead of lo…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10908214: Revert "Whenever possible use length passed to the List constructor for bounds checks instead of lo… (Closed)

Created:
8 years, 3 months ago by Vyacheslav Egorov (Google)

Modified:
8 years, 3 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert "Whenever possible use length passed to the List constructor for bounds checks instead of loading it from the array object itself." It completely eliminated bounds checks (Canonicalize method has to guarantee that replacement is inserted in the graph). R=fschneider@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=12259

Patch Set 1 #

Total comments: 1

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -141 lines)			Patch
M	runtime/vm/flow_graph_builder.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	8 chunks	+3 lines, -47 lines	1 comment	Download
M	runtime/vm/intermediate_language.cc	View	2 chunks	+0 lines, -27 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1 chunk	+0 lines, -32 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 chunk	+0 lines, -32 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

8 years, 3 months ago (2012-09-12 12:39:28 UTC) #3

https://chromiumcodereview.appspot.com/10908214/diff/1/runtime/vm/intermediat...
File runtime/vm/intermediate_language.h (right):

https://chromiumcodereview.appspot.com/10908214/diff/1/runtime/vm/intermediat...
runtime/vm/intermediate_language.h:2871: virtual bool HasSideEffect() const {
return false; }
Probably need to rebase to make sure it compiles.

Expand Messages | Collapse Messages