Issue 10908199: Fix unknownelement_test after recent rework.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10908199: Fix unknownelement_test after recent rework. (Closed)

Created:
8 years, 3 months ago by Anton Muhin

Modified:
8 years, 3 months ago

Reviewers:
vsm, Lasse Reichstein Nielsen, podivilov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix unknownelement_test after recent rework. R=lrn@google.com,podivilov@chromium.org,vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=12203

Patch Set 1 #

Total comments: 1

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -6 lines)			Patch
	M	tests/html/html.status	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	tests/html/unknownelement_test.dart	View		2 chunks	+5 lines, -5 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

https://chromiumcodereview.appspot.com/10908199/diff/1/tests/html/unknownelement_test.dart File tests/html/unknownelement_test.dart (right): https://chromiumcodereview.appspot.com/10908199/diff/1/tests/html/unknownelement_test.dart#newcode65 tests/html/unknownelement_test.dart:65: expect(() { foo.x = 7; }, throwsNoSuchMethodError); that doesn't ...

8 years, 3 months ago (2012-09-11 13:37:13 UTC) #2

lgtm

Expand Messages | Collapse Messages