Issue 10908185: Do not allocate a buffer of 64KB by default when writing a message out. Start

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10908185: Do not allocate a buffer of 64KB by default when writing a message out. Start (Closed)

Created:
8 years, 3 months ago by siva

Modified:
8 years, 3 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Fix for issue 1204. Do not allocate a buffer of 64KB by default when writing a message out. Start with a much smaller buffer. FOr script and full snapshots the buffer allocated remains 64 KB. Committed: https://code.google.com/p/dart/source/detail?r=12153

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -17 lines)			Patch
M	vm/dart_api_message.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	vm/datastream.h	View	3 chunks	+8 lines, -8 lines	0 comments	Download
M	vm/object.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	vm/snapshot.h	View	5 chunks	+14 lines, -6 lines	0 comments	Download
M	vm/snapshot_test.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages