Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 10908121: Do not close sockets for http connection fully before we are (Closed)

Created:
8 years, 3 months ago by Mads Ager (google)
Modified:
8 years, 3 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Do not close sockets for http connection fully before we are done writing data to them. This fixes the remaining skipped/failing http tests on Windows. R=sgjesse@google.com BUG=dartbug.com/2959 Committed: https://code.google.com/p/dart/source/detail?r=11951

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -8 lines) Patch
M runtime/bin/http_impl.dart View 2 chunks +10 lines, -6 lines 0 comments Download
M tests/standalone/standalone.status View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (google)
8 years, 3 months ago (2012-09-06 14:06:25 UTC) #1
Søren Gjesse
8 years, 3 months ago (2012-09-06 14:08:07 UTC) #2
lgtm

STV!

Powered by Google App Engine
This is Rietveld 408576698