Remove classes Computation and BindInstr.

Remove classes Computation and BindInstr.

The former Computation classes are folded into the Instruction class
hierarchy.

R=fschneider@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=11868

[Kevin Millikin (Google), 2012-09-05 10:37:03]

Please take a look.  There is a lot of cleanup needed (also a lot of new cleanup
enabled by this change).

I may have broken printing completely, I'll fix that in a separate change.

[Florian Schneider, 2012-09-05 11:14:42]

LGTM.

http://codereview.chromium.org/10908091/diff/1/runtime/vm/intermediate_langua...
File runtime/vm/intermediate_language.h (right):

http://codereview.chromium.org/10908091/diff/1/runtime/vm/intermediate_langua...
runtime/vm/intermediate_language.h:1165: virtual intptr_t GetPropagatedCid() {
return propagated_cid(); }
Move to .cc file as well?

http://codereview.chromium.org/10908091/diff/1/runtime/vm/intermediate_langua...
runtime/vm/intermediate_language.h:1166: virtual intptr_t ResultCid() const {
return kIllegalCid; }
UNREACHABLE();

[Kevin Millikin (Google), 2012-09-05 11:27:28]

http://codereview.chromium.org/10908091/diff/1/runtime/vm/intermediate_langua...
File runtime/vm/intermediate_language.h (right):

http://codereview.chromium.org/10908091/diff/1/runtime/vm/intermediate_langua...
runtime/vm/intermediate_language.h:1166: virtual intptr_t ResultCid() const {
return kIllegalCid; }
On 2012/09/05 11:14:42, Florian Schneider wrote:
> UNREACHABLE();

Oops, we can't.  As is, this is called in the type propagator.  I'll make it
UNREACHABLE (here) and check for IsPushArgument (there) to avoid calling it.

That matches exactly the previous behavior.