Issue 10908066: - Removed named constructor Stopwatch.start() due to conflict with instance methods start().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10908066: - Removed named constructor Stopwatch.start() due to conflict with instance methods start(). (Closed)

Created:
8 years, 3 months ago by bakster

Modified:
8 years, 3 months ago

Reviewers:
Lasse Reichstein Nielsen, kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Removed named constructor Stopwatch.start() due to conflict with instance methods start(). This change reduces errors reported by dart_analyser when cheking corelib. - Change comment format in newissues.dart. Committed: https://code.google.com/p/dart/source/detail?r=11801

Patch Set 1 #

Total comments: 1

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -29 lines)			Patch
M	lib/compiler/implementation/compiler.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	lib/core/stopwatch.dart	View	1 chunk	+5 lines, -5 lines	1 comment	Download
M	lib/coreimpl/stopwatch_implementation.dart	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	samples/leap/leap_leg.dart	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	samples/newissues/newissues.dart	View	4 chunks	+8 lines, -16 lines	0 comments	Download
M	tools/testing/legpad/legpad.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

kasperl

8 years, 3 months ago (2012-09-04 08:11:59 UTC) #2

DBC:

https://chromiumcodereview.appspot.com/10908066/diff/1/lib/core/stopwatch.dart
File lib/core/stopwatch.dart (left):

https://chromiumcodereview.appspot.com/10908066/diff/1/lib/core/stopwatch.dar...
lib/core/stopwatch.dart:18: Stopwatch.start();
Personally, I like naming constructor like these something along the lines of:

   Stopwatch.started()

because you're trying to create a thing in a certain state.

Expand Messages | Collapse Messages